From owner-cvs-all Sun Mar 10 0:30: 2 2002 Delivered-To: cvs-all@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id ABB6137B416; Sun, 10 Mar 2002 00:29:56 -0800 (PST) Received: (from luigi@localhost) by freefall.freebsd.org (8.11.6/8.11.6) id g2A8Tuj92742; Sun, 10 Mar 2002 00:29:56 -0800 (PST) (envelope-from luigi) Message-Id: <200203100829.g2A8Tuj92742@freefall.freebsd.org> From: Luigi Rizzo Date: Sun, 10 Mar 2002 00:29:56 -0800 (PST) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/dev/usb ufm.c X-FreeBSD-CVS-Branch: HEAD Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG luigi 2002/03/10 00:29:56 PST Modified files: sys/dev/usb ufm.c Log: Fix one genuine bug and a potential one: -#if defined(__FreeBSD__) && __FreeBSD_version__ >= 500023 +#if defined(__FreeBSD__) && __FreeBSD_version >= 500023 is a genuine bug -- __FreeBSD_version__ does not exist. The other one: -#if (__FreeBSD__ < 5) +#if (__FreeBSD_version < 500000) pops out when you cross-compile the code: __FreeBSD__ is a compiler predefine, __FreeBSD_version is defined in . Given that in this case (and all others in sys/dev/usb and sys/i4b) the goal is to adapt to a different kernel interface, and not to a compiler feature, I believe the correct form is the second one (in the best case the two are synonyms so the change does not break anything anyways). Revision Changes Path 1.2 +2 -2 src/sys/dev/usb/ufm.c To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message