Date: Wed, 6 Dec 2017 10:47:29 +0100 From: Mathieu Arnold <mat@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org>, Steve Wills <swills@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r455594 - in head/science/mcstas: . files Message-ID: <a5fdd024-f997-680f-da87-52311a6c6180@FreeBSD.org> In-Reply-To: <20171206070552.GA29159@FreeBSD.org> References: <201712051732.vB5HWbUA018987@repo.freebsd.org> <20171206070552.GA29159@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --FV1SNje9G9GelvRh0fiDpA1KoRT82WOIC Content-Type: multipart/mixed; boundary="wEQTJToWX7IfaJQIXA0TXO9vhDsVaCtIk"; protected-headers="v1" From: Mathieu Arnold <mat@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org>, Steve Wills <swills@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: <a5fdd024-f997-680f-da87-52311a6c6180@FreeBSD.org> Subject: Re: svn commit: r455594 - in head/science/mcstas: . files References: <201712051732.vB5HWbUA018987@repo.freebsd.org> <20171206070552.GA29159@FreeBSD.org> In-Reply-To: <20171206070552.GA29159@FreeBSD.org> --wEQTJToWX7IfaJQIXA0TXO9vhDsVaCtIk Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: fr Le 06/12/2017 =C3=A0 08:05, Alexey Dokuchaev a =C3=A9crit=C2=A0: > On Tue, Dec 05, 2017 at 05:32:37PM +0000, Steve Wills wrote: >> New Revision: 455594 >> URL: https://svnweb.freebsd.org/changeset/ports/455594 >> >> Log: >> science/mcstas: simplify Makefile >> =20 >> While here, remove unecessary pkg-install/deinstall >> =20 >> PR: 223905 >> Submitted by: Erik B Knudsen <erkn@fysik.dtu.dk> (maintainer) >> >> ... >> PORTNAME=3D mcstas >> -PORTVERSION=3D 2.2a >> +DISTVERSION=3D 2.2a > Ok, so PKGVERSION had changed now, I think you might need PORTEPOCH :( > > $ make -V PKGVERSION > 2.2.a > $ pkg version -t 2.2.a 2.2a > < > No need to bump PORTEPOCH, just put back PORTVERSION. >> =20 >> -PLIST_SUB+=3D PORTVERSION=3D${PORTVERSION} >> -SUB_FILES=3D pkg-deinstall pkg-install >> +MANDIRS=3D ${PREFIX}/${PORTNAME}/${DISTVERSION}/doc/man/man1 > There is MANPREFIX for manpages, but more importantly, why embed versio= n > in the path at all? > >> +PLIST_SUB+=3D DISTVERSION=3D${DISTVERSION} >> =20 >> +MCEXECS=3D mcstas mcformat >> + >> post-install: >> - ${STRIP_CMD} ${STAGEDIR}${PREFIX}/mcstas/${PORTVERSION}/bin/mcformat= >> - ${STRIP_CMD} ${STAGEDIR}${PREFIX}/mcstas/${PORTVERSION}/bin/mcstas >> +.for e in ${MCEXECS} >> + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/${PORTNAME}/${DISTVERSION}/bin/${e= } >> + ${LN} -s ${PREFIX}/${PORTNAME}/${DISTVERSION}/bin/${e} ${STAGEDIR}${= PREFIX}/bin/${e} > Symlinks should not point to an absolute path. > >> @@ -1,2 +1,3 @@ >> +TIMESTAMP =3D 1511649139 > This change was uncalled for since the remaining of distinfo was left > intact. It should have been removed from the commit bach to reduce > the diff noise and repo churn. > >> -mcstas/%%PORTVERSION%%/share/ref-lib.h >> -mcstas/%%PORTVERSION%%/share/vitess-lib.c >> -mcstas/%%PORTVERSION%%/share/vitess-lib.h >> +mcstas/%%DISTVERSION%%/LGPL >> +mcstas/%%DISTVERSION%%/LICENSE.LIB >> +mcstas/%%DISTVERSION%%/NOMENCLATURE >> +mcstas/%%DISTVERSION%%/README >> +mcstas/%%DISTVERSION%%/bin/mcformat >> +mcstas/%%DISTVERSION%%/bin/mcstas >> +mcstas/%%DISTVERSION%%/data/Al.nxs >> +mcstas/%%DISTVERSION%%/data/Cu.nxs >> +mcstas/%%DISTVERSION%%/doc/man/man1/mcformat-%%DISTVERSION%%.1.gz >> +mcstas/%%DISTVERSION%%/doc/man/man1/mcstas-%%DISTVERSION%%.1.gz > Ditt (what's the reason behind having PORTVERSION in the path? I don't= > see any potentially conflicting versions of the port in the tree. This= > also breaks its conformance to hier(7). > > ./danfe > > --=20 Mathieu Arnold --wEQTJToWX7IfaJQIXA0TXO9vhDsVaCtIk-- --FV1SNje9G9GelvRh0fiDpA1KoRT82WOIC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJaJ7zAXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85Iub0P/Rv7I5ZSccI653jjr/fH8DX+ /9LuhIMRUEVFGcNrE2cFYpE/DQHws8Bl8EkJDH9Jzt1Tm0hUSjf1xP+OnYB6Ni+f XkOvDITt9c7QzaLGSfyKAIxUMUFxpAt9rKWtAdC/AIaX/rBo+HrkDUvLIDkaBaf4 OOOBTdbNNCdts4sdDKnCD8OUvJADTtR6jFjOG3Ue3zUcozY716pzm40nc1c4rFA7 YLUfGyzhEAnCl+fyJbdFKj7iQ6dP7okkQAzxlLmVGLtKDigYkiOJr4LItHEZWU+m OJcgVHJTrz7t0Emea1DtSvAld4PwCO1v/DVikqQ4+I2PlrILYiwDYzHTiGbuDxTx 19g94dvCnaZ1ZqZpfFS+Y6VCR2ToC8KVvvmcffJ2dTcoefL8WEe43vkamldWpCWu uSKSKW2fVXPBB7oPm9cPYkBYC3A+PXSGX0HaLbT+F1ztps2jyOrFOL3UmGnAdM2V 2p8RNX+r4JavYdjfy+i8DuMmN9hJWvo4F/5tZ7I5d17UpfNfOnnUHlW7R8uWHBmA Ei7olIqreepsI7o2I1Zja5XCL1ZrELqv07sautng0rQKnLcAycnA6lQBWciZjexK NnLiCrS4r2k92CkIASiXCC3VlZDxzTzHDlyFeS0mzY/Ph9J1PfeJZX3ldxvZcf9/ 9xO3XeLPptv6xpPxcTXA =aWm4 -----END PGP SIGNATURE----- --FV1SNje9G9GelvRh0fiDpA1KoRT82WOIC--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a5fdd024-f997-680f-da87-52311a6c6180>