From owner-cvs-src@FreeBSD.ORG Mon May 5 18:27:05 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2DF151065677; Mon, 5 May 2008 18:27:05 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 1045A8FC12; Mon, 5 May 2008 18:27:04 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unknown [208.65.91.234]) by elvis.mu.org (Postfix) with ESMTP id AED3A1A4D84; Mon, 5 May 2008 11:27:04 -0700 (PDT) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m45IQjdq069338; Mon, 5 May 2008 14:26:52 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Marcel Moolenaar Date: Mon, 5 May 2008 14:26:07 -0400 User-Agent: KMail/1.9.7 References: <200805051614.m45GE3Ul089815@repoman.freebsd.org> <5D5D000D-9D30-4A9C-BB46-B301F9B46C89@mac.com> In-Reply-To: <5D5D000D-9D30-4A9C-BB46-B301F9B46C89@mac.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200805051426.07438.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Mon, 05 May 2008 14:26:52 -0400 (EDT) X-Virus-Scanned: ClamAV 0.91.2/7035/Mon May 5 13:47:07 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/include stdio.h src/lib/libc Versions.def src/lib/libc/stdio Symbol.map stdio.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 May 2008 18:27:05 -0000 On Monday 05 May 2008 12:42:52 pm Marcel Moolenaar wrote: > > On May 5, 2008, at 9:14 AM, John Baldwin wrote: > > > jhb 2008-05-05 16:14:03 UTC > > > > FreeBSD src repository > > > > Modified files: > > include stdio.h > > lib/libc Versions.def > > lib/libc/stdio Symbol.map stdio.c > > Log: > > Retire the __fgetcookie(), __fgetpendout(), and __fsetfileno() > > accessors > > as we aren't hiding FILE's internals anymore. > > Thanks for cleaning this up too! Sorry for the mess. It would be really nice if we could make FILE opaque, but apparently we can't. I was confused by glibc's headers (one of the 2 or 3 stdio.h's just declares 'FILE' as a typedef, but another header it always includes earlier (libio.h IIRC) does define the backing struct always) and thought glibc had one that was fully opaque. In practice I think glibc does inline some cases like feof_unlocked(). I think they do not inline getc() and putc() however. I think I can still fix _file to be an int (make existing _file _ofile instead and initialize it when setting _file) w/o breaking the ABI, but I need to chew on it some more. -- John Baldwin