From nobody Wed Feb 22 23:25:08 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PMXM02rYPz3sbjh; Wed, 22 Feb 2023 23:25:16 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PMXM02DDKz3s1t; Wed, 22 Feb 2023 23:25:16 +0000 (UTC) (envelope-from kevans@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1677108316; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ry5A5QPIsUfxVzgA/GCERv3B2ozWnz1kc1sCwGYXnP8=; b=mRyC+1YRl1lhZGvslLc4RHn6BaRJhZXD8fp24JtVPbEcNoG9qymMC9CLQEB3fJI/VbIwmS o2WccCWWlH8OdE7Csh7tD70nGu7tVrlm+XDgO3QCsYFzi6+S8FNgjwPv7lDj+OAONRV7Vs djd1PU+Ft3DLiFM5To/+VYRDyW2K4ZWs5iMUHrru/5miVuZyly4gZdeFTsN+lSsYIVaMzX KoixeztQsARBX34LkcWHiIf1BtVkuqnvtHAxWTpqu1LkXejUVpGnFzqE0OqTVJWs+9ienH ULz3Tp1wMM/C9uZKfzZThsLbbTFBFTjLqcmEgkstWcZMdXLzHYeJeYp+MrBcjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1677108316; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ry5A5QPIsUfxVzgA/GCERv3B2ozWnz1kc1sCwGYXnP8=; b=cdTgtzI009WMgSW7fi0n7TZpVxfmtJICY+sJlIHl+yE29c/TWiGaHqojJpuv7ZSvpSasPt vd2ZC18jSBYj8abLDvQlJ+WOaqj3uInBeXmEeqDzbxd6WqyuR3vbUptGzXTILNax0ol4K/ KJUQ1Ai7Rb76/2NBdpqwbB3HaoyXeU6Vg8amuRLmwa8CkWqJ2EuEF3H55XIlPlLCvgSkX3 6qO4WIYGdWfBP4GTEw6JvSakQi18saPFobOcRcnlprZQZ6zXqh+WNuoz7Tj9gtf2jlylFi cVbZAGkmp1v7ZeX8vqEhH4kb4dS9WszlozCUDI9Se/mcOTn52x74A3Yi0b4u/Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1677108316; a=rsa-sha256; cv=none; b=eadhh9tttIQ9hAFmBefWedJk4VuPf8lvWKHv/h8zw68i1SK8KZuXNSWK7+a8XlFhy3HQxV OmevffMU3XD1QNR8AH+gRd9OriKP+0kj3briKwZ+WzPk9wDBXb0cZZcCZnuFQjNfMzQWr3 lSvaf6pZ/DCBD9ABNO3FjOt7oqYbt1bWyw/5yIeji9AWUpNssV8IQU5XE5dcokXrDsG3na HlhDqa/8HNSlrQkjFV/T9Yf0NgymkBwP5clWFB+A3HzXhMpw/j8ibacfMPoj9L/x8eM3nW YatbuJ7PEeTfnZQVjs1kCRJzfrqxWbXAY/7wHsLMA5mrHnJnck+GJg2FOfsE2w== Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PMXM014LNz1C20; Wed, 22 Feb 2023 23:25:16 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qt1-f177.google.com with SMTP id d5so9158088qtn.13; Wed, 22 Feb 2023 15:25:16 -0800 (PST) X-Gm-Message-State: AO0yUKWOUu3UVLuEF0BLHbuRrpiJsNAI9a57tYvOLAVU746JsBa69o10 qPoH0UpaQn9Zu3IEYmrsakPJ3S1rAWIHzcRfW8E= X-Google-Smtp-Source: AK7set966P7wg9QGHvUT3s957aZTbzZ1TPbVBJADdAc/BRRwa82f8fGJ/ffTlrcFen4RXq3zQATPAQrPhFecoQ96mSU= X-Received: by 2002:ac8:40c8:0:b0:3b8:5484:d3eb with SMTP id f8-20020ac840c8000000b003b85484d3ebmr1392701qtm.1.1677108315480; Wed, 22 Feb 2023 15:25:15 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202302080610.3186AOCE091192@gitrepo.freebsd.org> In-Reply-To: From: Kyle Evans Date: Wed, 22 Feb 2023 17:25:08 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 29c5f8bf9a01 - main - config: drop dependency on libnv To: John Baldwin Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-ThisMailContainsUnwantedMimeParts: N On Wed, Feb 22, 2023 at 3:41 PM John Baldwin wrote: > > On 2/7/23 10:10 PM, Kyle Evans wrote: > > The branch main has been updated by kevans: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=29c5f8bf9a011d92462977bae59b4889ec5d95ad > > > > commit 29c5f8bf9a011d92462977bae59b4889ec5d95ad > > Author: Kyle Evans > > AuthorDate: 2023-02-08 06:02:56 +0000 > > Commit: Kyle Evans > > CommitDate: 2023-02-08 06:09:19 +0000 > > > > config: drop dependency on libnv > > > > Compile mkmakefile.c as C++ instead and use an std::unordered_map to > > accomplish the same goal. > > > > Reviewed by: imp > > Sponsored by: Klara, Inc. > > Sponsored by: NetApp, Inc. > > Differential Revision: https://reviews.freebsd.org/D38275 > > I'm not quite sure how to fix it, but I believe this change is what has broken > the clang-12 cross-build jobs on GitHub's actions. The error is a mismatch > in the declarations of getopt() as the Linux one adds a 'throw ()' specifier. > > Note that clang-13 on the newer Ubuntu 22.04 builds file. I haven't tried > examining the includes on 22.04 to see what has changed to avoid the error > there. > > [... snip ...] > > (FWIW, one odd thing here that I can't figure out yet is that it appears that > our local getopt.h was #included prior to the unistd.h wrapper which I think > is probably the root issue, may just need to wrap some other header?) > Yeah, this was pointed out to me a couple days ago. =( I looked at the include situation and couldn't make heads or tails of what was going on. jrtc27@ looked at it a bit and found some oddities in -I ordering. I don't think we've ended up at a solution to this problem quite yet. Thanks, Kyle Evans