From owner-cvs-all@FreeBSD.ORG  Fri May  6 07:03:37 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id E244016A4CE; Fri,  6 May 2005 07:03:37 +0000 (GMT)
Received: from harmony.village.org (rover.village.org [168.103.84.182])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 7A1E943D31; Fri,  6 May 2005 07:03:37 +0000 (GMT)
	(envelope-from imp@bsdimp.com)
Received: from localhost (warner@rover2.village.org [10.0.0.1])
	by harmony.village.org (8.13.3/8.13.1) with ESMTP id j4671c5v099501;
	Fri, 6 May 2005 01:01:38 -0600 (MDT)
	(envelope-from imp@bsdimp.com)
Date: Fri, 06 May 2005 01:02:35 -0600 (MDT)
Message-Id: <20050506.010235.56228082.imp@bsdimp.com>
To: gurney_j@resnet.uoregon.edu
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20050506065419.GE2670@funkthat.com>
References: <20050506062013.GD2670@funkthat.com>
	<20050506.002419.88383520.imp@bsdimp.com>
	<20050506065419.GE2670@funkthat.com>
X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
cc: cvs-src@freebsd.org
cc: src-committers@freebsd.org
cc: cvs-all@freebsd.org
cc: cperciva@freebsd.org
Subject: Re: cvs commit: src/sys/kern subr_bus.c subr_rman.c vfs_subr.c
 src/sys/net if_mib.c src/sys/netinet ip_divert.c raw_ip.c udp_usrreq.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 06 May 2005 07:03:38 -0000

In message: <20050506065419.GE2670@funkthat.com>
            John-Mark Gurney <gurney_j@resnet.uoregon.edu> writes:
: I didn't see any cases of this in the patches that were submitted, but
: I also only checked one file...

the one in subr_bus existed since day one.  Originally it was
snprintf.  I changed it to a strlcpy because snprintf was too heavy
weight for the job.  I've just implemented in my tree alloc with
B_ZERO with a free after the copyout.  struct u_device is a little too
big to put on the stack anyway...

Warner