From owner-svn-src-head@freebsd.org Thu Mar 29 23:10:26 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 02516F52C4F; Thu, 29 Mar 2018 23:10:26 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mx1.sbone.de (bird.sbone.de [46.4.1.90]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id B468A69CC5; Thu, 29 Mar 2018 23:10:25 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id 0147025D3A6D; Thu, 29 Mar 2018 23:10:22 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 31093D1F83D; Thu, 29 Mar 2018 23:10:22 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id Zieb_EPFvpTS; Thu, 29 Mar 2018 23:10:20 +0000 (UTC) Received: from [192.168.1.88] (fresh-ayiya.sbone.de [IPv6:fde9:577b:c1a9:f001::2]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 81230D1F822; Thu, 29 Mar 2018 23:10:20 +0000 (UTC) From: "Bjoern A. Zeeb" To: "Alexander V. Chernikov" Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r331098 - in head/sys: net netinet netinet6 Date: Thu, 29 Mar 2018 23:10:19 +0000 X-Mailer: MailMate (2.0BETAr6106) Message-ID: <99B864A7-2541-4EBF-BDF3-F24E1ABF11D0@lists.zabbadoz.net> In-Reply-To: <201803171705.w2HH5mk1054256@repo.freebsd.org> References: <201803171705.w2HH5mk1054256@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2018 23:10:26 -0000 On 17 Mar 2018, at 17:05, Alexander V. Chernikov wrote: > Author: melifaro > Date: Sat Mar 17 17:05:48 2018 > New Revision: 331098 > URL: https://svnweb.freebsd.org/changeset/base/331098 > > Log: > Fix outgoing TCP/UDP packet drop on arp/ndp entry expiration. > > Current arp/nd code relies on the feedback from the datapath > indicating > that the entry is still used. This mechanism is incorporated into > the > arpresolve()/nd6_resolve() routines. After the inpcb route cache > introduction, the packet path for the locally-originated packets > changed, > passing cached lle pointer to the ether_output() directly. This > resulted > in the arp/ndp entry expire each time exactly after the configured > max_age > interval. During the small window between the ARP/NDP request and > reply > from the router, most of the packets got lost. > > Fix this behaviour by plugging datapath notification code to the > packet > path used by route cache. Unify the notification code by using > single > inlined function with the per-AF callbacks. > > Reported by: sthaug at nethelp.no > Reviewed by: ae > MFC after: 2 weeks Does this mean that we now take an extra lock per-packet again? /bz