From owner-cvs-all@FreeBSD.ORG Tue Feb 17 14:43:23 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B03F016A4CE; Tue, 17 Feb 2004 14:43:23 -0800 (PST) Received: from mailout2.pacific.net.au (mailout2.pacific.net.au [61.8.0.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3541343D2F; Tue, 17 Feb 2004 14:43:23 -0800 (PST) (envelope-from bde@zeta.org.au) Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.0.86])i1HMhL5O030672; Wed, 18 Feb 2004 09:43:21 +1100 Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246]) i1HMhG0I002793; Wed, 18 Feb 2004 09:43:18 +1100 Date: Wed, 18 Feb 2004 09:43:16 +1100 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Marcel Moolenaar In-Reply-To: <20040217170647.GA95247@dhcp01.pn.xcllnt.net> Message-ID: <20040218093149.A19121@gamplex.bde.org> References: <200401192127.i0JLRBL3041817@repoman.freebsd.org> <20040213035557.M24031@gamplex.bde.org> <20040215094444.F6303@gamplex.bde.org> <20040217170647.GA95247@dhcp01.pn.xcllnt.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: Jun Kuriyama cc: src-committers@FreeBSD.org cc: Poul-Henning Kamp cc: cvs-all@FreeBSD.org cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha support.s src/sys/i386/i386 swtch.s src/sys/kern kern_shutdown.c src/sys/sys systm.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2004 22:43:23 -0000 On Tue, 17 Feb 2004, Marcel Moolenaar wrote: > On Tue, Feb 17, 2004 at 09:57:41PM +0900, Jun Kuriyama wrote: > > Sorry my stupid, but it seems everyone seems happy if traceback() > > improvement happens. Is that really too hard to go forward? > > Alternatively, we could extend KASSERT to emit a file and line > number like assert(3) and instead of panic(). Seems very logical > to me. That feature was intentionally left out when KASSERT() was designed. For some reason, we decided to give the invoker of KASSERT() complete control over the message contents (unlike in userland where the message is the condition stingized and followed by __FILE__ and __LINE__. Presumably this was partly to permit use of existing panic messages verbatim. I'm not completely happy with the results of this at any level, especially at the source level. It requires and ugly syntax (another layer of parentheses around the message), and is harder to write and can be harder to read (writers have to think about what to put in the message; it's normal to invert the sense of the assertion and not unknown to make logic errors doing so; then readers don't see the original condition in the panic message). Bruce