Date: Fri, 25 Oct 2024 16:29:39 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 279003] [NEW PORT] sysutils/kleene-daemon Kleene backend component for managing containers on FreeBSD. Message-ID: <bug-279003-7788-SaKwYfcOHW@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-279003-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-279003-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D279003 Robert Clausecker <fuz@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fuz@FreeBSD.org, | |olgeni@FreeBSD.org --- Comment #4 from Robert Clausecker <fuz@FreeBSD.org> --- Sorry for the delay. Patch needs some improvements. COMMENT should perhaps better read: COMMENT=3D Kleene backend daemon for managing containers on FreeBSD This is to avoid repetition in the comment, which is usually printed like kleene-daemon Kleene backend daemon for managing containers on FreeBSD and with your old COMMENT it would have been kleene-daemon Kleened, the Kleene backend daemon for managing containers on FreeBSD repeating itself. Please fix the indentation. When editing ports Makefiles, make sure to set your editor to hard tabs, 8 stops per tab. Indent with at least two tabs f= or make macros, one tab for make rules. It's okay if you indent entire blocks= of macros deeper if that is needed to give all values the same indentation. Please use USES=3Delixir if possible at all. I have added olgeni@ as a rev= iewer, who is more familiar with this stuff. Do not install binaries with COPYTREE_SHARE, use COPYTREE_BIN instead (this strips the binaries if needed). If you do this right, you won't need to explicitly strip any files. libexec/kleened/releases does not seem to be an appropriate path for the er= lang files. How do other erlang ports handle this? Try to copy what they do. Do not auto-generate the plist in post-install unless you have a very good reason to do so. "It's a lot of files" is not a good reason usually. What= is your reason here? --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-279003-7788-SaKwYfcOHW>