From owner-freebsd-current@freebsd.org Mon Dec 7 13:49:45 2015 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 652639A0579 for ; Mon, 7 Dec 2015 13:49:45 +0000 (UTC) (envelope-from freebsd-listen@fabiankeil.de) Received: from smtprelay01.ispgateway.de (smtprelay01.ispgateway.de [80.67.31.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EEC271A15 for ; Mon, 7 Dec 2015 13:49:44 +0000 (UTC) (envelope-from freebsd-listen@fabiankeil.de) Received: from [78.35.182.168] (helo=fabiankeil.de) by smtprelay01.ispgateway.de with esmtpsa (TLSv1.2:AES128-GCM-SHA256:128) (Exim 4.84) (envelope-from ) id 1a5w53-0001sL-Ro for freebsd-current@FreeBSD.org; Mon, 07 Dec 2015 14:43:54 +0100 Date: Mon, 7 Dec 2015 14:43:53 +0100 From: Fabian Keil To: freebsd-current@FreeBSD.org Subject: panic: devfs_fsync: vop_stdfsync failed. Message-ID: <20151207144353.6fd09a40@fabiankeil.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/AhYOJ/WbpzKFYrDJerPGVHC"; protocol="application/pgp-signature" X-Df-Sender: Nzc1MDY3 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Dec 2015 13:49:45 -0000 --Sig_/AhYOJ/WbpzKFYrDJerPGVHC Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable I got the following panic by impatiently unplugging a device while a msdosfs partition on it was in the process of getting unmounted: Unread portion of the kernel message buffer: [368] Device IPOD went missing before all of the data could be written to i= t; expect data loss. [368] fsync: giving up on dirty [368] 0xfffff80011b24760: tag devfs, type VCHR [368] usecount 1, writecount 0, refcount 4770 mountedhere 0xfffff800061= eb200 [368] flags (VI_DOOMED|VI_ACTIVE) [368] v_object 0xfffff80011a4c500 ref 0 pages 4782 cleanbuf 4766 dirtyb= uf 1 [368] lock type devfs: EXCL by thread 0xfffff80010c424d0 (pid 40394, su= do, tid 101528) [368] dev msdosfs/IPOD [368] panic: devfs_fsync: vop_stdfsync failed. [...] (kgdb) where #0 doadump (textdump=3D0) at pcpu.h:221 #1 0xffffffff80316e5b in db_dump (dummy=3D, dummy2=3D= false, dummy3=3D0, dummy4=3D0x0) at /usr/src/sys/ddb/db_command.c:533 #2 0xffffffff80316c4e in db_command (cmd_table=3D0x0) at /usr/src/sys/ddb/= db_command.c:440 #3 0xffffffff803169e4 in db_command_loop () at /usr/src/sys/ddb/db_command= .c:493 #4 0xffffffff803194eb in db_trap (type=3D, code=3D0) = at /usr/src/sys/ddb/db_main.c:251 #5 0xffffffff805e2923 in kdb_trap (type=3D3, code=3D0, tf=3D) at /usr/src/sys/kern/subr_kdb.c:654 #6 0xffffffff8087cb27 in trap (frame=3D0xfffffe009464a0b0) at /usr/src/sys= /amd64/amd64/trap.c:549 #7 0xffffffff80861ad7 in calltrap () at /usr/src/sys/amd64/amd64/exception= .S:234 #8 0xffffffff805e200b in kdb_enter (why=3D0xffffffff8096fb7b "panic", msg= =3D0x32
) at cpufunc.h:63 #9 0xffffffff8059e5af in vpanic (fmt=3D, ap=3D) at /usr/src/sys/kern/kern_shutdown.c:750 #10 0xffffffff8059e403 in panic (fmt=3D0x0) at /usr/src/sys/kern/kern_shutd= own.c:688 #11 0xffffffff80459e1f in devfs_fsync (ap=3D) at /usr/= src/sys/fs/devfs/devfs_vnops.c:688 #12 0xffffffff80902206 in VOP_FSYNC_APV (vop=3D, a=3D<= value optimized out>) at vnode_if.c:1328 #13 0xffffffff8063dba5 in bufsync (bo=3D, waitfor=3D) at vnode_if.h:549 #14 0xffffffff8065bc3c in bufobj_invalbuf (bo=3D0xfffff80011b24830, flags= =3D1, slpflag=3D0, slptimeo=3D0) at /usr/src/sys/kern/vfs_subr.c:1517 #15 0xffffffff8065f23e in vgonel (vp=3D) at /usr/src/s= ys/kern/vfs_subr.c:1595 #16 0xffffffff8065f8e7 in vgone (vp=3D0xfffff80011b24760) at /usr/src/sys/k= ern/vfs_subr.c:3006 #17 0xffffffff80453152 in devfs_delete (dm=3D0xfffff80002428080, de=3D0xfff= ff800062d2d00, flags=3D0) at /usr/src/sys/fs/devfs/devfs_devs.c:390 #18 0xffffffff80453663 in devfs_populate_loop (dm=3D0xfffff80002428080, cle= anup=3D) at /usr/src/sys/fs/devfs/devfs_devs.c:528 #19 0xffffffff8045344a in devfs_populate (dm=3D0xfffff80002428080) at /usr/= src/sys/fs/devfs/devfs_devs.c:655 #20 0xffffffff8045914e in devfs_populate_vp (vp=3D0xfffff80006130588) at /u= sr/src/sys/fs/devfs/devfs_vnops.c:239 #21 0xffffffff80456c4c in devfs_lookup (ap=3D0xfffffe009464a6d8) at /usr/sr= c/sys/fs/devfs/devfs_vnops.c:1042 #22 0xffffffff80900e90 in VOP_LOOKUP_APV (vop=3D, a=3D= ) at vnode_if.c:127 #23 0xffffffff8065131e in lookup (ndp=3D0xfffffe009464a9b0) at vnode_if.h:54 #24 0xffffffff806509f1 in namei (ndp=3D) at /usr/src/s= ys/kern/vfs_lookup.c:306 #25 0xffffffff8066ed7c in vn_open_cred (ndp=3D0xfffffe009464a9b0, flagp=3D0= xfffffe009464aa8c, cmode=3D0, vn_open_flags=3D0, cred=3D0xfffff80010467400,= fp=3D0xfffff8000633c780) at /usr/src/sys/kern/vfs_vnops.c:277 #26 0xffffffff80667eef in kern_openat (td=3D0xfffff80010c424d0, fd=3D-100, = path=3D0x41527f
, pathseg=3DUIO_USERSPACE, = flags=3DCannot access memory at address 0x32 ) at /usr/src/sys/kern/vfs_syscalls.c:1005 #27 0xffffffff8087db2b in amd64_syscall (td=3D0xfffff80010c424d0, traced=3D= 0) at subr_syscall.c:140 #28 0xffffffff80861dbb in Xfast_syscall () at /usr/src/sys/amd64/amd64/exce= ption.S:394 #29 0x0000000800f4d7aa in ?? () Previous frame inner to this frame (corrupt stack?) Current language: auto; currently minimal (kgdb) f 11 #11 0xffffffff80459e1f in devfs_fsync (ap=3D) at /usr/= src/sys/fs/devfs/devfs_vnops.c:688 688 panic("devfs_fsync: vop_stdfsync failed."); (kgdb) l - 678 if (!vn_isdisk(ap->a_vp, &error)) { 679 bo =3D &ap->a_vp->v_bufobj; 680 de =3D ap->a_vp->v_data; 681 if (error =3D=3D ENXIO && bo->bo_dirty.bv_cnt > 0) { 682 printf("Device %s went missing before all of the data " 683 "could be written to it; expect data loss.\n", 684 de->de_dirent->d_name); 685=09 686 error =3D vop_stdfsync(ap); 687 if (bo->bo_dirty.bv_cnt !=3D 0 || error !=3D 0) (kgdb) l 688 panic("devfs_fsync: vop_stdfsync failed."); Shouldn't vop_stdfsync() be expected to fail if the device went missing? My kernel is based on r291864 but the printf+panic code was added years ago in r186911 and the commit message suggests that it prevents a different panic: commit d72b8ba20f3993d4517a73171cb5e4a269b103a6 Author: trasz Date: Thu Jan 8 19:13:34 2009 +0000 Don't panic with "vinvalbuf: dirty bufs" when the mounted device that w= as being written to goes away. Fabian --Sig_/AhYOJ/WbpzKFYrDJerPGVHC Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlZljRoACgkQBYqIVf93VJ3+hQCfa+v/+eoT7EUPWP1zu2juBRa3 /cgAnjkvjeuZn62G+dBJQw28bhceoDDq =QjKs -----END PGP SIGNATURE----- --Sig_/AhYOJ/WbpzKFYrDJerPGVHC--