Date: Tue, 02 Mar 2010 01:45:59 +0100 (CET) From: Alexander Best <alexbestms@wwu.de> To: jhell <jhell@DataIX.net> Cc: FreeBSD Hackers <freebsd-hackers@freebsd.org> Subject: Re: `make cleanworld` and /usr/obj/lib32/usr/src Message-ID: <permail-2010030200455980e26a0b00003b40-a_best01@message-id.uni-muenster.de> In-Reply-To: <alpine.BSF.2.00.1003011830380.22516@pragry.qngnvk.ybpny>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
jhell schrieb am 2010-03-02:
> On Mon, 1 Mar 2010 14:52, alexbestms@ wrote:
> >oh. and btw: wouldn't it be reasonable to prevent a user shooting
> >himself in
> >the foot if he has the brilliant idea of setting "MAKEOBJDIRPREFIX
> >= /" ?
> >alex
> Trying to match something like this is going to get out of control.
> Though this is a nice idea but why should a user be prevented from
> doing such things ?.
> Boiling down these are not variables that usually have to be changed
> and if they are changed the user has done a little bit of research
> and is more advanced than most and recognizes that / is not a option.
hmmm...so you think something like this won't be useful?
alex
> --
> jhell
[-- Attachment #2 --]
Index: Makefile
===================================================================
--- Makefile (revision 204540)
+++ Makefile (working copy)
@@ -112,6 +112,9 @@
.error MAKEOBJDIRPREFIX can only be set in environment, not as a global\
(in make.conf(5)) or command-line variable.
.endif
+.if ${MAKEOBJDIRPREFIX} == "/"
+.error MAKEOBJDIRPREFIX musn't point to the root directory.
+.endif
MAKEPATH= ${MAKEOBJDIRPREFIX}${.CURDIR}/make.${MACHINE}
BINMAKE= \
`if [ -x ${MAKEPATH}/make ]; then echo ${MAKEPATH}/make; else echo ${MAKE}; fi` \
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?permail-2010030200455980e26a0b00003b40-a_best01>