From owner-svn-src-all@FreeBSD.ORG Sun Sep 16 14:24:49 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 89303106566B; Sun, 16 Sep 2012 14:24:49 +0000 (UTC) (envelope-from tijl@coosemans.org) Received: from mailrelay009.isp.belgacom.be (mailrelay009.isp.belgacom.be [195.238.6.176]) by mx1.freebsd.org (Postfix) with ESMTP id 723318FC08; Sun, 16 Sep 2012 14:24:47 +0000 (UTC) X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgUFADvgVVBbsSJD/2dsb2JhbABFhUBHtgqBCIIgAQEFIzMiARALDgoJFgsCAgkDAgECASceBg0BBQIBAYgAB6dvkWmLIYVWgRIDjmmBIIZtjw2CaA Received: from 67.34-177-91.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([91.177.34.67]) by relay.skynet.be with ESMTP; 16 Sep 2012 16:24:39 +0200 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.14.5/8.14.5) with ESMTP id q8GEOcZk042835; Sun, 16 Sep 2012 16:24:38 +0200 (CEST) (envelope-from tijl@coosemans.org) Message-ID: <5055E121.2030208@coosemans.org> Date: Sun, 16 Sep 2012 16:24:33 +0200 From: Tijl Coosemans User-Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:14.0) Gecko/20120804 Thunderbird/14.0 MIME-Version: 1.0 To: Eitan Adler References: <201209142347.q8ENlN7N034951@svn.freebsd.org> <5054EBCB.6070105@coosemans.org> <5054F116.8090503@cran.org.uk> In-Reply-To: X-Enigmail-Version: 1.4.2 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig64D04E78E6E01D521E57E296" Cc: Bruce Cran , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r240527 - head/bin/df X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Sep 2012 14:24:49 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig64D04E78E6E01D521E57E296 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 16-09-2012 01:27, Eitan Adler wrote: > On 15 September 2012 17:20, Bruce Cran wrote: >> On 15/09/2012 21:57, Tijl Coosemans wrote: >>> >>> Freeing memory right before exiting is a waste of time. The tool shou= ldn't >>> complain about it. >=20 > Perhaps, but tools do. This has already been brought up on cfe-dev. >=20 >> "/Stop wasting time and just exit already/." - >> http://blogs.msdn.com/b/oldnewthing/archive/2012/01/05/10253268.aspx >=20 > I read this blog post when it came out. :) In this case the free is actually wrong, because the pointer can point to memory allocated by getmntinfo(3) and that manpage says an application= cannot free it. --------------enig64D04E78E6E01D521E57E296 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iF4EAREIAAYFAlBV4SYACgkQfoCS2CCgtiumFAD+LnchYDKAQbLekIn2QPiSI6cp 1fP1DNaeX+1N5Mu+jI4A/2PDG2/qlwF+499uPoZQjXQ1DfkMFO2VYUY69V1VKU+h =0FKG -----END PGP SIGNATURE----- --------------enig64D04E78E6E01D521E57E296--