Date: Sun, 01 May 2016 20:01:45 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 209183] Uses/bdb.mk conversion appears broken Message-ID: <bug-209183-13-ndwteFxz4u@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-209183-13@https.bugs.freebsd.org/bugzilla/> References: <bug-209183-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D209183 --- Comment #4 from Peter Wemm <peter@FreeBSD.org> --- The old code had: -# Override USE_BDB with global WITH_BDB_VER -.if defined(WITH_BDB_VER) -. if ${WITH_BDB_VER} !=3D 1 -USE_BDB=3D ${WITH_BDB_VER} -. endif -.endif - -# Override USE_BDB with maintainer's WANT_BDB_VER -.if defined(WANT_BDB_VER) -USE_BDB=3D ${WANT_BDB_VER} -.endif The new code has: +# Override _bdb_ARGS with global WITH_BDB_VER if the maintainer did not +# ask for a more specific version. +.if defined(WITH_BDB_VER) +. if ${WITH_BDB_VER} !=3D 1 && ${_bdb_ARGS} =3D=3D yes +_bdb_ARGS=3D ${WITH_BDB_VER} +. endif +.endif This is a loss of functionality. If the maintainer says "43+", then why does that have to mean "ignore the user's request for 48 and use db5 unconditionally" instead? At the very least it should exclude plus versions from this rule. "43+" is not "more specific" than "48" at all. --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-209183-13-ndwteFxz4u>