From owner-cvs-all Sat Jun 10 2:51:16 2000 Delivered-To: cvs-all@freebsd.org Received: from gidora.zeta.org.au (gidora.zeta.org.au [203.26.10.25]) by hub.freebsd.org (Postfix) with SMTP id CC15337BCB7 for ; Sat, 10 Jun 2000 02:51:08 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: (qmail 8157 invoked from network); 10 Jun 2000 09:51:05 -0000 Received: from unknown (HELO bde.zeta.org.au) (203.2.228.102) by gidora.zeta.org.au with SMTP; 10 Jun 2000 09:51:05 -0000 Date: Sat, 10 Jun 2000 19:51:01 +1000 (EST) From: Bruce Evans X-Sender: bde@besplex.bde.org To: Peter Wemm Cc: mjacob@feral.com, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf options In-Reply-To: <20000610085530.6755E1CE1@overcee.netplex.com.au> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sat, 10 Jun 2000, Peter Wemm wrote: > Matthew Jacob wrote: > > > > Say, Peter, could you honor the MAINTAINER rules and at least let me know wha > t > > you want here? > > Quoting LINT: > > # ISP_DISABLE_1020_SUPPORT Disable support for 1020/1040 cards > # ISP_DISABLE_1080_SUPPORT Disable support for 1080/1240 cards > # ISP_DISABLE_12160_SUPPORT Disable support for 12160 cards > # ISP_DISABLE_2100_SUPPORT Disable support for 2100 cards > # ISP_COMPILE_FW - compile all firmware in > # ISP_COMPILE_1020_FW - compile in 1020/1040 firmware > # ISP_COMPILE_1080_FW - compile in 1080/1240/1280 firmware > # ISP_COMPILE_12160_FW - compile in 12160 firmware > # ISP_COMPILE_2100_FW - compile in 2100 firmware > # ISP_COMPILE_2200_FW - compile in 2200 firmware > > The advertised ISP_DISABLE_12160_SUPPORT and ISP_COMPILE_12160_FW were > missing from conf/options. They should either be added to conf/options > (like I did), or removed from LINT. > > Incidently, ISP_DISABLE_2200_SUPPORT is missing from the docs in LINT. Also, LINT doesn't actually lint any of the ISP_COMPILE_* options. Only negative options like ISP_DISABLE_* should be commented out in LINT. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message