From owner-svn-src-head@FreeBSD.ORG Mon Oct 14 13:54:24 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id F0F66A5F; Mon, 14 Oct 2013 13:54:23 +0000 (UTC) (envelope-from pluknet@gmail.com) Received: from mail-wg0-x22f.google.com (mail-wg0-x22f.google.com [IPv6:2a00:1450:400c:c00::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 2433629D6; Mon, 14 Oct 2013 13:54:23 +0000 (UTC) Received: by mail-wg0-f47.google.com with SMTP id c11so2404243wgh.14 for ; Mon, 14 Oct 2013 06:54:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=uVzHOTovk9P6AaHCaauxbISjvXQjM82frFksUJf6CPo=; b=Ut6M4MTGJA4E0cUSV4NtuJTvZDvr4EdEgMZWFOj/3jcUhR2CZxnAVm/2SEwv3G1LnV /JKSjTD5V/yvS36HMZK8tsAN5Udhwo+wGYpK6MvygtlgPytZ8tTdlHubMnPEpMs+D7ai vIxvGfUjeytyspKhfGz4bj2NOn7O6b0GMwe20xIM6ue+DR0MqkPaY5+DTOAO/aAHPjJf 2Ic1I7WX6w0B3VhArmC1UUkgw71/+RBZXRQ8JUoG9aBmNqaoYi/o3btdXVPqbfTi203j AQ0kSkiyp3ECxF+XW1PupUfwGBtVc3D1CEzj3vAK8FoJlJ1O5+aLZV/CuppHbkQZZknf TYPA== MIME-Version: 1.0 X-Received: by 10.180.206.42 with SMTP id ll10mr14850982wic.50.1381758861515; Mon, 14 Oct 2013 06:54:21 -0700 (PDT) Sender: pluknet@gmail.com Received: by 10.216.62.69 with HTTP; Mon, 14 Oct 2013 06:54:21 -0700 (PDT) In-Reply-To: <201303082033.r28KXpKK057468@svn.freebsd.org> References: <201303082033.r28KXpKK057468@svn.freebsd.org> Date: Mon, 14 Oct 2013 17:54:21 +0400 X-Google-Sender-Auth: SDWjGNQopA0Iyn9vSBCag37AfQk Message-ID: Subject: Re: svn commit: r248070 - head/sys/net From: Sergey Kandaurov To: "Alexander V. Chernikov" Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Oct 2013 13:54:24 -0000 On 9 March 2013 00:33, Alexander V. Chernikov wrote: > Author: melifaro > Date: Fri Mar 8 20:33:50 2013 > New Revision: 248070 > URL: http://svnweb.freebsd.org/changeset/base/248070 > > Log: > Fix long-standing issue with interface routes being unprotected: > Use RTM_PINNED flag to mark route as immutable. > Forbid deleting immutable routes without special rtrequest1_fib() flag. > Adding interface address with prefix already in route table is handled > by atomically deleting old prefix and adding interface one. > > Discussed with: andre, eri > MFC after: 3 weeks [...] > Modified: head/sys/net/route.h > ============================================================================== > --- head/sys/net/route.h Fri Mar 8 20:23:55 2013 (r248069) > +++ head/sys/net/route.h Fri Mar 8 20:33:50 2013 (r248070) > @@ -176,7 +176,7 @@ struct ortentry { > /* 0x20000 unused, was RTF_WASCLONED */ > #define RTF_PROTO3 0x40000 /* protocol specific routing flag */ > /* 0x80000 unused */ > -#define RTF_PINNED 0x100000 /* future use */ > +#define RTF_PINNED 0x100000 /* route is immutable */ > #define RTF_LOCAL 0x200000 /* route represents a local address */ > #define RTF_BROADCAST 0x400000 /* route represents a bcast address */ > #define RTF_MULTICAST 0x800000 /* route represents a mcast address */ man rtentry(9) still references it as "Reserved for future use". Probably this simple change should suffice: Index: share/man/man9/rtentry.9 =================================================================== --- share/man/man9/rtentry.9 (revision 256125) +++ share/man/man9/rtentry.9 (working copy) @@ -28,7 +28,7 @@ .\" .\" $FreeBSD$ .\" -.Dd December 11, 2008 +.Dd October 14, 2013 .Dt RTENTRY 9 .Os .Sh NAME @@ -154,8 +154,7 @@ .It Dv RTF_PRCLONING This flag is obsolete and simply ignored by facility. .It Dv RTF_PINNED -(Reserved for future use to indicate routes which are not to be -modified by a routing protocol.) +Indicates that this route is immutable to a routing protocol. .It Dv RTF_LOCAL Indicates that the destination of this route is an address configured as belonging to this system. -- wbr, pluknet