From owner-freebsd-stable@FreeBSD.ORG Sun Feb 17 10:44:55 2008 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C73C816A41B for ; Sun, 17 Feb 2008 10:44:55 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from relay02.kiev.sovam.com (relay02.kiev.sovam.com [62.64.120.197]) by mx1.freebsd.org (Postfix) with ESMTP id 7F1BD13C448 for ; Sun, 17 Feb 2008 10:44:55 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from [212.82.216.226] (helo=skuns.kiev.zoral.com.ua) by relay02.kiev.sovam.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.67) (envelope-from ) id 1JQh0u-0006Q7-5T for freebsd-stable@freebsd.org; Sun, 17 Feb 2008 12:44:54 +0200 Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by skuns.kiev.zoral.com.ua (8.14.1/8.14.1) with ESMTP id m1HAiB1Z050895 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 17 Feb 2008 12:44:11 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.2/8.14.2) with ESMTP id m1HAiWNP048141; Sun, 17 Feb 2008 12:44:32 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.2/8.14.2/Submit) id m1HAiVFj048140; Sun, 17 Feb 2008 12:44:31 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 17 Feb 2008 12:44:31 +0200 From: Kostik Belousov To: David Naylor Message-ID: <20080217104431.GN57756@deviant.kiev.zoral.com.ua> References: Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="b5bTySBq8oFySjZL" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: ClamAV version 0.91.2, clamav-milter version 0.91.2 on skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.3 X-Spam-Checker-Version: SpamAssassin 3.2.3 (2007-08-08) on skuns.kiev.zoral.com.ua X-Scanner-Signature: 717fb1dce93df3d9117221529acf11a8 X-DrWeb-checked: yes X-SpamTest-Envelope-From: kostikbel@gmail.com X-SpamTest-Group-ID: 00000000 X-SpamTest-Header: Not Detected X-SpamTest-Info: Profiles 2246 [Feb 15 2008] X-SpamTest-Info: helo_type=3 X-SpamTest-Method: none X-SpamTest-Rate: 0 X-SpamTest-Status: Not detected X-SpamTest-Status-Extended: not_detected X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0278], KAS30/Release Cc: freebsd-stable@freebsd.org Subject: Re: tmpfs: strange behaviour (was: broken buildkernel (scsi_low and -Os) and duplicate manpages) X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Feb 2008 10:44:55 -0000 --b5bTySBq8oFySjZL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Feb 17, 2008 at 09:35:28AM +0200, David Naylor wrote: > On 14/02/2008, Oliver Fromme wrote: > > David Naylor wrote: > > > It is a strange problem, normal installworld works fine, but somehow > > > the duplicate manpages result in a failure when installing with > > > DESTDIR=3D, here are some possible reasons: > > > > > > 1) I use tmpfs when using DESTDIR (could be tmpfs does something str= ange) > > > 2) Base system (compiled and installed) is compiled using -O2??? > > > > What is the exact CFLAGS setting that you use? > > Do you use -O2 (or -Os) without -fno-strict-aliasing? > I have managed to isolate the problem and it is definitely tmpfs > related. If the directory that I'm installing into is tmpfs then it > will fail, if it is ufs then it works. >=20 > I recompiled tmpfs module (and reloaded) with CFLAGS=3D'' with the same r= esult. >=20 > As an aside I have found that the default CFLAGS for src are: -O2 > -fno-strict-aliasing -pipe. Would -fstrict-aliasing break anything in > base/sys? I suspect this is a known issue. See the following commit: delphij 2007-11-18 04:52:41 UTC FreeBSD src repository Modified files: sys/fs/tmpfs tmpfs.h tmpfs_subr.c tmpfs_vfsops.c=20 tmpfs_vnops.c=20 Log: MFp4: Several fixes to tmpfs which makes it to survive from pho@'s strees2 suite, to quote his letter, this change: =20 1. It removes the tn_lookup_dirent stuff. I think this cannot be fixed, because nothing protects vnode/tmpfs node between lookup is done, and actual operation is performed, in the case the vnode lock is dropped. At least, this is the case with the from vnode for rename. =20 For now, we do the linear lookup in the parent node. This has its own drawbacks. Not mentioning speed (that could be fixed by using hash), t= he real problem is the situation where several hardlinks exist in the dvp. But, I think this is fixable. ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Esp. this part. =20 2. The patch restores the VV_ROOT flag on the root vnode after it became reclaimed and allocated again. This fixes MPASS assertion at the start of the tmpfs_lookup() reported by many. =20 Submitted by: kib =20 Revision Changes Path 1.12 +2 -6 src/sys/fs/tmpfs/tmpfs.h 1.13 +25 -3 src/sys/fs/tmpfs/tmpfs_subr.c 1.14 +0 -1 src/sys/fs/tmpfs/tmpfs_vfsops.c 1.12 +19 -23 src/sys/fs/tmpfs/tmpfs_vnops.c --b5bTySBq8oFySjZL Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (FreeBSD) iEYEARECAAYFAke4EA4ACgkQC3+MBN1Mb4jgcgCgs7/8yHTjrp+lDcSdqwm1thtY lDoAmwSSHYltWWHvdWQRauYbjvdsYo3d =veEp -----END PGP SIGNATURE----- --b5bTySBq8oFySjZL--