From owner-cvs-all@FreeBSD.ORG Thu Apr 19 08:02:51 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E594D16A40D; Thu, 19 Apr 2007 08:02:51 +0000 (UTC) (envelope-from jkoshy@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id AEAA213C487; Thu, 19 Apr 2007 08:02:51 +0000 (UTC) (envelope-from jkoshy@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3J82psw027641; Thu, 19 Apr 2007 08:02:51 GMT (envelope-from jkoshy@repoman.freebsd.org) Received: (from jkoshy@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3J82pW2027640; Thu, 19 Apr 2007 08:02:51 GMT (envelope-from jkoshy) Message-Id: <200704190802.l3J82pW2027640@repoman.freebsd.org> From: Joseph Koshy Date: Thu, 19 Apr 2007 08:02:51 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/kern subr_witness.c src/sys/dev/hwpmc hwpmc_logging.c hwpmc_mod.c hwpmc_piv.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Apr 2007 08:02:52 -0000 jkoshy 2007-04-19 08:02:51 UTC FreeBSD src repository Modified files: sys/kern subr_witness.c sys/dev/hwpmc hwpmc_logging.c hwpmc_mod.c hwpmc_piv.c Log: Fix witness(4) warnings about mutex use. Group mutexes used in hwpmc(4) into 3 "types" in the sense of witness(4): - leaf spin mutexes---only one of these should be held at a time, so these mutexes are specified as belonging to a single witness type "pmc-leaf". - `struct pmc_owner' descriptors are protected by a spin mutex of witness type "pmc-owner-proc". Since we call wakeup_one() while holding these mutexes, the witness type of these mutexes needs to dominate that of "sleepq chain" mutexes. - logger threads use a sleep mutex, of type "pmc-sleep". Submitted by: wkoszek (earlier patch) Revision Changes Path 1.7 +3 -2 src/sys/dev/hwpmc/hwpmc_logging.c 1.28 +26 -17 src/sys/dev/hwpmc/hwpmc_mod.c 1.14 +1 -1 src/sys/dev/hwpmc/hwpmc_piv.c 1.230 +10 -0 src/sys/kern/subr_witness.c