From owner-freebsd-bugs@FreeBSD.ORG  Sun Nov  4 11:27:51 2007
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5F07116A41A;
	Sun,  4 Nov 2007 11:27:51 +0000 (UTC)
	(envelope-from iedowse@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 4E67613C4AA;
	Sun,  4 Nov 2007 11:27:51 +0000 (UTC)
	(envelope-from iedowse@FreeBSD.org)
Received: from freefall.freebsd.org (iedowse@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.1/8.14.1) with ESMTP id lA4BRpDB049488;
	Sun, 4 Nov 2007 11:27:51 GMT
	(envelope-from iedowse@freefall.freebsd.org)
Received: (from iedowse@localhost)
	by freefall.freebsd.org (8.14.1/8.14.1/Submit) id lA4BRpg8049484;
	Sun, 4 Nov 2007 11:27:51 GMT (envelope-from iedowse)
Date: Sun, 4 Nov 2007 11:27:51 GMT
Message-Id: <200711041127.lA4BRpg8049484@freefall.freebsd.org>
To: danny@cs.huji.ac.il, iedowse@FreeBSD.org, freebsd-bugs@FreeBSD.org,
	iedowse@FreeBSD.org
From: iedowse@FreeBSD.org
Cc: 
Subject: Re: bin/117603: [patch] dump(8) hangs on SMP - 4way and higher.
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 04 Nov 2007 11:27:51 -0000

Synopsis: [patch] dump(8) hangs on SMP - 4way and higher.

State-Changed-From-To: open->feedback
State-Changed-By: iedowse
State-Changed-When: Sun Nov 4 11:14:19 UTC 2007
State-Changed-Why: 

Hi, thanks for submitting this. I wonder could you try the patch
at

  http://people.freebsd.org/~iedowse/dump_117603.diff

instead? There appears to be one problem with the original patch,
as it passes an invalid NULL argument to sigsuspend(), which would
have caused it to return immediately with an EFAULT errno. As far
as I can tell that would have broken the synchronisation and caused
blocks to be written out of order at times.


Responsible-Changed-From-To: freebsd-bugs->iedowse
Responsible-Changed-By: iedowse
Responsible-Changed-When: Sun Nov 4 11:14:19 UTC 2007
Responsible-Changed-Why: 
I'll take this

http://www.freebsd.org/cgi/query-pr.cgi?pr=117603