From nobody Fri Oct 17 15:02:42 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cp7NL2yPGz6CB1H; Fri, 17 Oct 2025 15:02:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cp7NL2JgDz4236; Fri, 17 Oct 2025 15:02:42 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760713362; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ax9Waeb6utH+AVF/c5TQY3k00Q47MkbxsccEZh2a2ek=; b=gk7Lzvv0P0/oyd3nCd4CnNmQ9aLy2zwQiRblGcjsnMffa5K29yUwCVlduSW3iSIZC3/QuU GK3ruQV0ZAdHybjmOrLN/hqIHU72I7ev26VJi080HXPUgiwbzpLgnCMASTJ5j/cN1mXJLn QD0tXo6X1qHQP8Iy0xvrGQ3PQYxLy0A9E7bU1yDfk7dC4PjxXgh4aqVCUKGLt9NLR9gHdC iQpssrrdDvY3M/zAPN2mmE1qsF7X6kFsXeJJIW6sKXlrsnDH+ClkJEL/dItOJRRiBYMEHW bjoYzza+bkb728MgBvXnzS6eLObQ/Cgb3LxO4zG1u5q7fgyAQ70Iha0v1xGCHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760713362; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ax9Waeb6utH+AVF/c5TQY3k00Q47MkbxsccEZh2a2ek=; b=qT3wrTUoJ/Q6sWphbuwLZ98kAaS2zqVnpbX3VxHRghVKktGaItxzFY3eINA3TVpOn+35bd dONRPcYsfz6VXGbk8RsrWnKhZSWPvvIRbI/i38OceP02ByPiXwL4qQ7XLfglkhQk1RFSu0 hybHlLEZl0OwWeDn31Y8LOStkPmSaC2J4mxt3yV4a4+1vlqwEog4H9mM/qW4CHHH4ZeD5y tqrWCDWvO8aqdTJBZN6S8wsF4/W9feddfb46eNX/8Gl9vsIguXtQ7SdWqNka7VTPABRSaj 2bYNZrP0VA+Oi43Gl+959o+XaNGdXY89suMrFVwmVFIZpqwk4TxXtBV9r3+8+Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1760713362; a=rsa-sha256; cv=none; b=Ghgrfq/43mNrIvifZCidIHXbnX34LPaID0qWAP27uyLk2XH/YsUDEwHAFkikFph1VYGJa6 TlhY+2fvSQk/RJTiPssEMK8T6mG4CYgUGBF5DFJOP8E7Nj73dLxTU1fDINY1Fxq/AiOn7e 2eIsr0pyVvZS7TyK1M3WrECzEQ0oaGP3T5jFMw94H8UG+4J2gzGGMsL+U64u7PMfne45gY qLYtQzwdPCjswiIbPxZRhEgmAqNRrJamcIpWCTkD7VLCG8ua4lm30KPoal+4kui2sXapVH Z/NPAsBmvi9JrcSULuvDzL2qeuqIBCdmZke1qlFu8ir2nAtouXVAuVvXFFtCFA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cp7NL1gzLz10KH; Fri, 17 Oct 2025 15:02:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 59HF2grT063557; Fri, 17 Oct 2025 15:02:42 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 59HF2gjZ063554; Fri, 17 Oct 2025 15:02:42 GMT (envelope-from git) Date: Fri, 17 Oct 2025 15:02:42 GMT Message-Id: <202510171502.59HF2gjZ063554@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Andrew Turner Subject: git: edbbf26e2650 - main - pci/n1sdp: Disable HotPlug List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: andrew X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: edbbf26e2650e02cd3925dd1deaacf9b8fb2e2a0 Auto-Submitted: auto-generated The branch main has been updated by andrew: URL: https://cgit.FreeBSD.org/src/commit/?id=edbbf26e2650e02cd3925dd1deaacf9b8fb2e2a0 commit edbbf26e2650e02cd3925dd1deaacf9b8fb2e2a0 Author: Andrew Turner AuthorDate: 2025-10-17 15:02:19 +0000 Commit: Andrew Turner CommitDate: 2025-10-17 15:02:19 +0000 pci/n1sdp: Disable HotPlug Work around an issue when HotPlug is enabled where pcib3 and pcib5 continuously report the following: pcib3: HotPlug interrupt: 0x30 pcib3: Command Completed pcib3: HotPlug interrupt: 0x30 pcib3: Command Completed ... As a workaround disable HotPlug on the N1SDP as it's unlikely anyone will depend on it. Reviewed by: br Fixes: 1f5c50a86173 ("pci_host_generic:Add pcib_request_feature on ACPI") Sponsored by: Arm Ltd Differential Revision: https://reviews.freebsd.org/D53134 --- sys/dev/pci/controller/pci_n1sdp.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/sys/dev/pci/controller/pci_n1sdp.c b/sys/dev/pci/controller/pci_n1sdp.c index 487041bc78e4..22f0ea27d45b 100644 --- a/sys/dev/pci/controller/pci_n1sdp.c +++ b/sys/dev/pci/controller/pci_n1sdp.c @@ -345,6 +345,17 @@ n1sdp_pcie_write_config(device_t dev, u_int bus, u_int slot, bus_space_write_4(t, h, offset & ~3, data); } +static int +n1sdp_pcie_acpi_request_feature(device_t pcib __unused, device_t dev __unused, + enum pci_feature feature __unused) +{ + /* + * HotPlug isn't supported on the N1SDP as it causes an interrupt storm + */ + return (EINVAL); +} + + static device_method_t n1sdp_pcie_acpi_methods[] = { DEVMETHOD(device_probe, n1sdp_pcie_acpi_probe), DEVMETHOD(device_attach, n1sdp_pcie_acpi_attach), @@ -352,6 +363,7 @@ static device_method_t n1sdp_pcie_acpi_methods[] = { /* pcib interface */ DEVMETHOD(pcib_read_config, n1sdp_pcie_read_config), DEVMETHOD(pcib_write_config, n1sdp_pcie_write_config), + DEVMETHOD(pcib_request_feature, n1sdp_pcie_acpi_request_feature), DEVMETHOD_END };