Date: Mon, 27 May 2019 14:26:22 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r232071 - head/sys/vm Message-ID: <20190527142622.GA4921@FreeBSD.org> In-Reply-To: <20190527112155.GZ2748@kib.kiev.ua> References: <201202232107.q1NL7GHi023139@svn.freebsd.org> <20190527095256.GA52203@FreeBSD.org> <20190527112155.GZ2748@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, May 27, 2019 at 02:21:55PM +0300, Konstantin Belousov wrote: > On Mon, May 27, 2019 at 09:52:56AM +0000, Alexey Dokuchaev wrote: > > On Thu, Feb 23, 2012 at 09:07:16PM +0000, Konstantin Belousov wrote: > > > ... > > > + /* > > > + * Decrement the object's writemappings, by swapping the start > > > + * and end arguments for vnode_pager_update_writecount(). If > > > + * there was not a race with vnode reclaimation, then the > > > + * vnode's v_writecount is decremented. > > > + */ > > > + vnode_pager_update_writecount(object, end, start); > > > > ... here, first `end' is passed, then `start'. Is this intentional? > Did you read the comment right before the call ? I did, as I thought that explanation might be there, but it evaded me (also, I was subconsciously expecting it near the end of the comment), thanks for bring it to my attention and sorry for the noise. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190527142622.GA4921>