From owner-svn-src-all@FreeBSD.ORG Sun Feb 28 18:07:31 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4ABC5106566C; Sun, 28 Feb 2010 18:07:31 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 939928FC08; Sun, 28 Feb 2010 18:07:30 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id o1SI7SKK089297 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 28 Feb 2010 20:07:28 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id o1SI7SIR023906; Sun, 28 Feb 2010 20:07:28 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id o1SI7SVB023905; Sun, 28 Feb 2010 20:07:28 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 28 Feb 2010 20:07:28 +0200 From: Kostik Belousov To: Attilio Rao Message-ID: <20100228180728.GP2489@deviant.kiev.zoral.com.ua> References: <201002281713.o1SHD74Q040738@svn.freebsd.org> <3bbf2fe11002281000i5a6ebb35seadd6cb8f506d65e@mail.gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IihjUyvzd0n5Ehsu" Content-Disposition: inline In-Reply-To: <3bbf2fe11002281000i5a6ebb35seadd6cb8f506d65e@mail.gmail.com> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r204470 - head/sys/fs/msdosfs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Feb 2010 18:07:31 -0000 --IihjUyvzd0n5Ehsu Content-Type: text/plain; charset=koi8-r Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Feb 28, 2010 at 07:00:10PM +0100, Attilio Rao wrote: > 2010/2/28 Konstantin Belousov : > > Author: kib > > Date: Sun Feb 28 17:13:07 2010 > > New Revision: 204470 > > URL: http://svn.freebsd.org/changeset/base/204470 > > > > Log: > > =9AAdd per-mountpoint lockmgr lock for msdosfs. It is intended to be us= ed > > =9Aas fat bitmap lock and to replace global mutex protecting fileno rbt= ree. >=20 > Looking at this patch, it seems you can safely use a sx lock here and > I would prefer that as we don't want to encourage more lockmgr to get > in. > If you are concerned about writer starvation in any way here, > probabilly the right solution is to implement it in sx and remove > lockmgr also from the export code. There is no write starvation in the msdosfs case, because all locks are acquired exclusively (this is not true for the export list locking, and write starvation is real issue there). I used lockmgr mostly because it is fs code. --IihjUyvzd0n5Ehsu Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAkuKsOAACgkQC3+MBN1Mb4g3TgCfXM3msusBi8gxeTtHkvBVoIIh hTEAnA16WubWpC+4p7q8LbtHVp8D5SFj =Pl/2 -----END PGP SIGNATURE----- --IihjUyvzd0n5Ehsu--