Date: Sun, 6 Oct 2019 10:11:14 +0200 From: Tobias Kortkamp <tobik@freebsd.org> To: Gleb Popov <arrowd@freebsd.org> Cc: Mikhail Teterin <mi@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r513679 - head/sysutils/fusefs-smbnetfs/files Message-ID: <20191006081114.GA33887@urd.tobik.me> In-Reply-To: <CALH631=WA=D2gRWG4t72CMr4Z%2BOt5303ZV-1ng0uQ0ZiRGs1WA@mail.gmail.com> References: <201910031745.x93Hje5x059120@repo.freebsd.org> <20191006054444.GB62549@urd.tobik.me> <CALH631=WA=D2gRWG4t72CMr4Z%2BOt5303ZV-1ng0uQ0ZiRGs1WA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--AhhlLboLdkugWU4S Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 06, 2019 at 11:59:10AM +0400, Gleb Popov wrote: > On Sun, Oct 6, 2019 at 9:44 AM Tobias Kortkamp <tobik@freebsd.org> wrote: >=20 > > On Thu, Oct 03, 2019 at 05:45:40PM +0000, Mikhail Teterin wrote: > > > Author: mi > > > Date: Thu Oct 3 17:45:39 2019 > > > New Revision: 513679 > > > URL: https://svnweb.freebsd.org/changeset/ports/513679 > > > > > > Log: > > > Add a patch from upstream, fixing the author's typo in an option's > > name. > > > It only affects users of libsecret, which is off by default -- thus= no > > > port-revision bump. > > > > That's not a valid reason not to bump PORTREVISION. Please bump > > it so that users how happen to build it with LIBSECRET=3Don get your > > fix automatically. > > >=20 > I have been told that PORTREVISION should be bumped whenever output packa= ge > changes. It isn't the case here. Or am I mistaken? We do not have options specific PORTREVISIONs and there are more package repositories than pkg.FreeBSD.org. If you have previously built your packages with LIBSECRET=3Don, the applied fix will change the package in a non-trivial way. However since PORTREVISION was not bumped Poudriere or other package builders will not rebuild the package. Bascially people will have to micromanage/force the rebuild fusefs-smbnetfs if they want this fix. fusefs-smbnetfs is hardly an expensive package to build so saving rebuilds at the cost of wasting people's time is not worth it and bad UX. --AhhlLboLdkugWU4S Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEElXvTEJc6ePgdQuobpPCftzzFH2EFAl2ZoaBfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk1 N0JEMzEwOTczQTc4RjgxRDQyRUExQkE0RjA5RkI3M0NDNTFGNjEACgkQpPCftzzF H2HoGAf+JO+PUjXZz1QboAzSlnzvK1AJwVrp8SKYEtqXVZllTtlzw93X01SVym02 T9szhFLJz8KGin9Clmcv/a5wgFxzkoyUJIXPX5iJKDhtVUt+apig7123OH0kQzJ9 +q2VLBkvCGmQjkS5US3cwwEmHchCeWPXsp6l8K9vg8qxPcGo8aZL+r0iMyyIaqLP SH9Ocr8TdNBDhM+9F6Fz5khKes6xnoV+YjyFJbuYPRtObqVW+pDx4W7Rw6Daca/Y Z0GUn2hURJ6YeQ05r5kr6zMo4eQafIB2HmBSq1EJ1eTkLLF6SaKd33tGfiBO+pha bdTxBdTAxjVO9XUwdJx0sMedxemwMg== =qUph -----END PGP SIGNATURE----- --AhhlLboLdkugWU4S--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20191006081114.GA33887>