Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 16 Aug 2021 21:02:50 GMT
From:      Vladimir Kondratyev <wulf@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: cb910670ac59 - main - hmt(4): Do not ignore constant usages in HID report descriptor parser
Message-ID:  <202108162102.17GL2oJi036929@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by wulf:

URL: https://cgit.FreeBSD.org/src/commit/?id=cb910670ac59e11808a629c8375c60200f909217

commit cb910670ac59e11808a629c8375c60200f909217
Author:     Jack <MrLightningBolt@users.noreply.github.com>
AuthorDate: 2021-08-16 20:17:41 +0000
Commit:     Vladimir Kondratyev <wulf@FreeBSD.org>
CommitDate: 2021-08-16 20:24:05 +0000

    hmt(4): Do not ignore constant usages in HID report descriptor parser
    
    This fixes hmt to work with MELF0411 1FD2:7012 touchscreen
    
    Obtained from:  sysutils/iichid
    MFC after:      1 week
---
 sys/dev/hid/hmt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sys/dev/hid/hmt.c b/sys/dev/hid/hmt.c
index 2eb02811a5a4..d04db6954d00 100644
--- a/sys/dev/hid/hmt.c
+++ b/sys/dev/hid/hmt.c
@@ -676,8 +676,8 @@ hmt_hid_parse(struct hmt_softc *sc, const void *d_ptr, hid_size_t d_len,
 	bool scan_time_found = false;
 	bool has_int_button = false;
 
-#define HMT_HI_ABSOLUTE(hi)	\
-	(((hi).flags & (HIO_CONST|HIO_VARIABLE|HIO_RELATIVE)) == HIO_VARIABLE)
+#define HMT_HI_ABSOLUTE(hi)	((hi).nusages != 0 &&	\
+	((hi).flags & (HIO_VARIABLE | HIO_RELATIVE)) == HIO_VARIABLE)
 #define	HUMS_THQA_CERT	0xC5
 
 	/*



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202108162102.17GL2oJi036929>