From nobody Sat Feb 21 16:29:10 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fJCHV70MHz6SsZc for ; Sat, 21 Feb 2026 16:29:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fJCHV4Ympz3sMx for ; Sat, 21 Feb 2026 16:29:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771691350; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1oL/U8Ay1p1HSiFR1iWnl6o14yTi4EPBCglU+1p6oGQ=; b=ws61cNL72uoxjddI7V59ln7amImhN/fYu2S3tZteneLIuf8P2fhqHxSbZuruK6bkNE31w5 fEfHIManYvrroKgNK0Vvy6k1I6va6nkSH7dEWpW8u18y5SNnwkVcLvjk3AY4rCJKWo7nMB ei3Sfe8l4RUZ4f5/G/2vq1pkHitq6M33P4DJD951KxoR/b6uM/mxDzjtO4WxkpbFmmvC8x AIdtEEz3BpZ7WLf4ldR+B5IEy3vQdeCqrj5Wd6X9q58iqoWqBKOiLX0NlSCZdCvp7NsKMR MhH9NsAKMYOQuF5ZDnQsoajFpKxSvfRSF2Hg6OFlHRM5kP1Ra002/XSYcstERw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1771691350; a=rsa-sha256; cv=none; b=grxL1Wh/UubgOLF8yeqEJGcS1e6E0mSVUVjT1faPOQYBBDP8d72/laLmfRXFtb6xW2juld ciD/nQ4uzqLH0kJvvrW9hdNzF6qmGA2Awhe3HMOrPHMD/ZDRVIQshGD2dRLPVK+Ej2/I1o pcXCdDRBZV65EGofJAxzWEabgf2K/hmfyIsrbJZTyzrfoa/Wo0QSfVsDtohlXmoZnSjrP0 TsJGxOeylKAzNQotMRtiaGPJ2+CB7CC8f8XXcKr40Bfe71pJoW2GvssKCKTzFdJPpjjbr2 324HGTtXJJ6KQu3s2Lm0irvFyleGo9InVsdNPSU8a1YctULkbHnfMxcVFCQnvg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771691350; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1oL/U8Ay1p1HSiFR1iWnl6o14yTi4EPBCglU+1p6oGQ=; b=V5M33ZsQa4rr1MZAb/QwE1wRXx2AxHbXSzjP2nWNBGT4S45RZy5b0XlIXe8PxhCxYtNaFo 5EcpX5FdTG299qAj2pTBKNPQCSqOcOEdkJW/qOPxxJzMtq1a+0+LN+IJ7swsqLPf6HAPhj EckEZNNWMMo2hllt349sctUjj5f0dt9iooqCzTcKJZQV9kwfsFcrYEUxjwx29M59Db8tEm oNqm2QBMAQhJB7eP8dGnjWo4/3LZKmwSQ9tx4A5l7fnNm1sB3So7bgWWTqC6/m7EQJAlaz 9n79CQ45diB30RwEu6A3r/NRs87/knhoUPBBd3lJz2ETMy8MUC7//bddpBNbGQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fJCHV46VRz1LKR for ; Sat, 21 Feb 2026 16:29:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 31de2 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 21 Feb 2026 16:29:10 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: fa77660a3ccb - main - pipe: Avoid unnecessary priv_check() calls in pipespace_new() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: fa77660a3ccbd5f30e88093703b0f93892ef35d7 Auto-Submitted: auto-generated Date: Sat, 21 Feb 2026 16:29:10 +0000 Message-Id: <6999dd56.31de2.20b92c19@gitrepo.freebsd.org> The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=fa77660a3ccbd5f30e88093703b0f93892ef35d7 commit fa77660a3ccbd5f30e88093703b0f93892ef35d7 Author: Mark Johnston AuthorDate: 2026-02-21 16:28:49 +0000 Commit: Mark Johnston CommitDate: 2026-02-21 16:28:49 +0000 pipe: Avoid unnecessary priv_check() calls in pipespace_new() Running out of pipe map KVA is a rare case, so reorder checks accordingly, presuming that calling priv_check() is more expensive than the calculation. In particular, priv_check() might not be cheap to evaluate if MAC hooks are installed. Reviewed by: olce, kib MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D55378 --- sys/kern/sys_pipe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/kern/sys_pipe.c b/sys/kern/sys_pipe.c index 6531cea31423..e928de1cd776 100644 --- a/sys/kern/sys_pipe.c +++ b/sys/kern/sys_pipe.c @@ -592,8 +592,8 @@ retry: } vm_map_lock(pipe_map); - if (priv_check(curthread, PRIV_PIPEBUF) != 0 && maxpipekva / 100 * - (100 - pipebuf_reserv) < amountpipekva + size) { + if (maxpipekva / 100 * (100 - pipebuf_reserv) < amountpipekva + size && + priv_check(curthread, PRIV_PIPEBUF) != 0) { vm_map_unlock(pipe_map); chgpipecnt(cpipe->pipe_pair->pp_owner->cr_ruidinfo, -size, 0); if (cpipe->pipe_buffer.buffer == NULL &&