From owner-svn-src-user@FreeBSD.ORG Tue Mar 2 05:35:04 2010 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 87BEA106564A; Tue, 2 Mar 2010 05:35:04 +0000 (UTC) (envelope-from juli@clockworksquid.com) Received: from qw-out-2122.google.com (qw-out-2122.google.com [74.125.92.26]) by mx1.freebsd.org (Postfix) with ESMTP id 39A3D8FC0A; Tue, 2 Mar 2010 05:35:03 +0000 (UTC) Received: by qw-out-2122.google.com with SMTP id 8so771819qwh.7 for ; Mon, 01 Mar 2010 21:34:55 -0800 (PST) MIME-Version: 1.0 Sender: juli@clockworksquid.com Received: by 10.224.53.80 with SMTP id l16mr2985951qag.345.1267508095109; Mon, 01 Mar 2010 21:34:55 -0800 (PST) In-Reply-To: <20100301.223049.864843819497816567.imp@bsdimp.com> References: <201003010521.o215LZqd002772@svn.freebsd.org> <20100301.223049.864843819497816567.imp@bsdimp.com> From: Juli Mallett Date: Mon, 1 Mar 2010 21:34:35 -0800 X-Google-Sender-Auth: 9a6723f8c02819c6 Message-ID: To: "M. Warner Losh" Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Cc: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: Re: svn commit: r204507 - in user/jmallett/octeon/sys/mips: include mips X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Mar 2010 05:35:04 -0000 On Mon, Mar 1, 2010 at 21:30, M. Warner Losh wrote: > In message: <201003010521.o215LZqd002772@svn.freebsd.org> > =A0 =A0 =A0 =A0 =A0 =A0Juli Mallett writes: > : Author: jmallett > : Date: Mon Mar =A01 05:21:35 2010 > : New Revision: 204507 > : URL: http://svn.freebsd.org/changeset/base/204507 > : > : Log: > : =A0 o) Adjust ptr and register macros for assembly wrt ABI in a way tha= t ought to > : =A0 =A0 =A0work better. =A0Need to check for places where the assembly = assumes pointers > : =A0 =A0 =A0are register width, I guess. > > NetBSD has much better asm.h foo, which I'd hoped to import to help > with this problem... I think that's a great idea =97 especially now that they have n32 and n64 support. Likewise for their PIC and GP macros. In general I'd hope to have time to spend cleaning up mips/include =97 I took a swipe at some KSEG related things, for example. There's a lot of duplication and a large number of vestigal interfaces, types and declarations. The duplication is especially worrying as we move towards 64-bit support, where a stray macro in an underused port can be terribly hard to track down as the source of corruption or invalid addresses. Juli.