From owner-svn-src-head@FreeBSD.ORG  Fri Feb 25 22:22:45 2011
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E94BC106566B;
	Fri, 25 Feb 2011 22:22:45 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id BEEB28FC12;
	Fri, 25 Feb 2011 22:22:45 +0000 (UTC)
Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net
	[66.111.2.69])
	by cyrus.watson.org (Postfix) with ESMTPSA id 6154D46B0C;
	Fri, 25 Feb 2011 17:22:45 -0500 (EST)
Received: from jhbbsd.localnet (unknown [209.249.190.10])
	by bigwig.baldwin.cx (Postfix) with ESMTPSA id F25E68A01D;
	Fri, 25 Feb 2011 17:22:44 -0500 (EST)
From: John Baldwin <jhb@freebsd.org>
To: Dmitry Chagin <dchagin@freebsd.org>
Date: Fri, 25 Feb 2011 17:21:28 -0500
User-Agent: KMail/1.13.5 (FreeBSD/7.4-CBSD-20110107; KDE/4.4.5; amd64; ; )
References: <201102252205.p1PM5Xlr013873@svn.freebsd.org>
In-Reply-To: <201102252205.p1PM5Xlr013873@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201102251721.28461.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6
	(bigwig.baldwin.cx); Fri, 25 Feb 2011 17:22:45 -0500 (EST)
X-Virus-Scanned: clamav-milter 0.96.3 at bigwig.baldwin.cx
X-Virus-Status: Clean
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r219042 - in head/sys: kern sys
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Feb 2011 22:22:46 -0000

On Friday, February 25, 2011 5:05:33 pm Dmitry Chagin wrote:
> Author: dchagin
> Date: Fri Feb 25 22:05:33 2011
> New Revision: 219042
> URL: http://svn.freebsd.org/changeset/base/219042
> 
> Log:
>   Introduce preliminary support of the show description of the ABI of
>   traced process by adding two new events which records value of process
>   sv_flags to the trace file at process creation/execing/exiting time.
>   
>   MFC after:	1 Month.

Hmm, I don't find ktrace_submitrequest_ne() an intuitive name (took a bit
to figure out 'not-entered', and it doesn't map well between getrequest()
(where it means 'already-entered') and submitrequest ('don't exit')).

I would rather only have submitrequest() and getrequest() and push the
ktrace_enter() and ktrace_exit() into all the callers.

-- 
John Baldwin