From owner-freebsd-geom@freebsd.org  Fri Apr 21 20:38:19 2017
Return-Path: <owner-freebsd-geom@freebsd.org>
Delivered-To: freebsd-geom@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 64874D49317
 for <freebsd-geom@mailman.ysv.freebsd.org>;
 Fri, 21 Apr 2017 20:38:19 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 544961B30
 for <freebsd-geom@FreeBSD.org>; Fri, 21 Apr 2017 20:38:19 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v3LKcIxO098290
 for <freebsd-geom@FreeBSD.org>; Fri, 21 Apr 2017 20:38:19 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-geom@FreeBSD.org
Subject: [Bug 218512] Geli arbitrarily prevents setting passphrases
Date: Fri, 21 Apr 2017 20:38:19 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: CURRENT
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Many People
X-Bugzilla-Who: fhriley@gmail.com
X-Bugzilla-Status: In Progress
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-geom@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-218512-14739-8UXZmK927m@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-218512-14739@https.bugs.freebsd.org/bugzilla/>
References: <bug-218512-14739@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-geom@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: GEOM-specific discussions and implementations
 <freebsd-geom.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-geom>,
 <mailto:freebsd-geom-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-geom/>
List-Post: <mailto:freebsd-geom@freebsd.org>
List-Help: <mailto:freebsd-geom-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
 <mailto:freebsd-geom-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Apr 2017 20:38:19 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D218512

--- Comment #14 from Frank <fhriley@gmail.com> ---
(In reply to Alexander Motin from comment #13)

"Multiple processes running same time indeed likely cause different number =
of
iterations to be set on different disks."

If you recognize that, you should see the problem. Say we have three disks,=
 you
set passphrases on them and they end up with the following iterations:

1: 10
2: 11
3: 10

Now you come along and want to change the passphrase (without using -i), and
this time it computes the iterations as so:

1: 11
2: 10
3: 10

With the current code and your commit, disks 1 & 2 will fail because it sees
you trying to change the iterations. Here is your if statement:

if (*valp !=3D -1 && md.md_iterations =3D=3D -1) {
    md.md_iterations =3D *valp;
} else if (*valp !=3D -1 && *valp !=3D md.md_iterations) {
    /* fail */
}

For disk 1 above in setting the passphrase the second time:

*valp =3D=3D 11
md_md_iterations =3D=3D 10

This is fixed in my pull request.

--=20
You are receiving this mail because:
You are the assignee for the bug.=