From owner-freebsd-bugs@FreeBSD.ORG Tue Oct 19 21:50:08 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0FF441065670 for ; Tue, 19 Oct 2010 21:50:08 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id C68788FC12 for ; Tue, 19 Oct 2010 21:50:07 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o9JLo7SS020330 for ; Tue, 19 Oct 2010 21:50:07 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o9JLo7jf020329; Tue, 19 Oct 2010 21:50:07 GMT (envelope-from gnats) Resent-Date: Tue, 19 Oct 2010 21:50:07 GMT Resent-Message-Id: <201010192150.o9JLo7jf020329@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Andrew Boyer Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9CF0410656A7 for ; Tue, 19 Oct 2010 21:40:09 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 87E068FC08 for ; Tue, 19 Oct 2010 21:40:09 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o9JLe81W068959 for ; Tue, 19 Oct 2010 21:40:08 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id o9JLe8ta068947; Tue, 19 Oct 2010 21:40:08 GMT (envelope-from nobody) Message-Id: <201010192140.o9JLe8ta068947@www.freebsd.org> Date: Tue, 19 Oct 2010 21:40:08 GMT From: Andrew Boyer To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/151586: [patch] [ipmi] Incorrect firmware version printed at boot time X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2010 21:50:08 -0000 >Number: 151586 >Category: kern >Synopsis: [patch] [ipmi] Incorrect firmware version printed at boot time >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Oct 19 21:50:07 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Andrew Boyer >Release: head >Organization: Avere Systems >Environment: N/A >Description: The ipmi driver prints out some status information when the driver loads: ipmi0: on isa0 ipmi0: KCS mode found at io 0xca2 alignment 0x1 on isa ipmi0: IPMI device rev. 1, firmware rev. 1.2, version 2.0 ipmi0: Number of channels 8 I noticed that the 'firmware rev' is not correct. In this case, the rev should be 1.60 (hex) or 1.96 (dec). The wrong byte is used in the printf statement. See IPMI 2.0 spec 1.0 Table 20-2 on page 240. >How-To-Repeat: Compare the printed firmware rev to the installed firmware. >Fix: --- a/src/sys/dev/ipmi/ipmi.c +++ b/src/sys/dev/ipmi/ipmi.c @@ -726,7 +726,7 @@ ipmi_startup(void *arg) device_printf(dev, "IPMI device rev. %d, firmware rev. %d.%d, " "version %d.%d\n", req->ir_reply[1] & 0x0f, - req->ir_reply[2] & 0x0f, req->ir_reply[4], + req->ir_reply[2] & 0x0f, req->ir_reply[3], req->ir_reply[4] & 0x0f, req->ir_reply[4] >> 4); ipmi_free_request(req); >Release-Note: >Audit-Trail: >Unformatted: