From owner-svn-src-head@freebsd.org Thu Dec 22 20:56:09 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D37BAC8D684; Thu, 22 Dec 2016 20:56:09 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-it0-x243.google.com (mail-it0-x243.google.com [IPv6:2607:f8b0:4001:c0b::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9CECAEEB; Thu, 22 Dec 2016 20:56:09 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-it0-x243.google.com with SMTP id 75so22150773ite.1; Thu, 22 Dec 2016 12:56:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=+g3LzCztI93SwgwiiP7+DQhW2SHsYrGkNU8PDZCPXSY=; b=cn2Vyy3Bu956JQAyMR1ZnyFY5IcGk2LszZ+m3mT2u2IkYwNbzwG4oyhQtCS5dfvE6R 7KFETpXOtzehH5lB3ATdq4SuFyEuayqEOSTcwFejINzxvNqmeqD0RaiELMkghbJ//uuJ 3IoDlmdXu4bSCXYfHPDy20MEeD5foe43w0+VMFMIvhE7aXPF8FLXL0up1OOU+nTqFM2e jxEZTXAkCFg5jv85yxgh/wAZqdvalHJpqWROmbGXKgquQVSz+Gs4KuJdQWyftqhx/vRM ra9SjR2xS77SJTb5ISJzatZRro2f2zekX3eWU50sntLJgts3vetK9T/WLRSztri2KCuF +cNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=+g3LzCztI93SwgwiiP7+DQhW2SHsYrGkNU8PDZCPXSY=; b=H5nshCL4BqO6bvkS+g8FoF/gtUepljF8A1j7wbPaCY25U/BieRSxluaWj48uE868dX GAAyPdwS6qtGStotkDJqpakFqiEOh4frtdkzvQiDpzPhFC8Tm1bdyrEKXv+/3r5vsaJK gImX70dH+qDh8k6/b5z98mNoDZ5use62EimnP7b5iWv/vggbgIQwQDuTiE5w9lObRvl5 4VKvkfA8GYsw5AUTHMw06rPptLBG43uUsyRr9QSa9CcijzBY4UPihKgi8qhe7o4s7eTT vFIjvBLsKZZpf7O/6x8b6lAugPdLFs+b5gOA+CbsgdmfZ5aGDj5A84cQ5Zff2lEyKgUX Pu7Q== X-Gm-Message-State: AIkVDXJ9nmPwTpXg90M1tlhnMIaUILngbwlnZ1teweWWQ6Sg2iqrbndaXkamkQdygYfeaD8Z7yqtUwzYuOu8LQ== X-Received: by 10.36.77.5 with SMTP id l5mr11485066itb.83.1482440168743; Thu, 22 Dec 2016 12:56:08 -0800 (PST) MIME-Version: 1.0 Sender: carpeddiem@gmail.com Received: by 10.107.175.133 with HTTP; Thu, 22 Dec 2016 12:55:48 -0800 (PST) In-Reply-To: References: <201612221826.uBMIQLFQ076247@repo.freebsd.org> From: Ed Maste Date: Thu, 22 Dec 2016 15:55:48 -0500 X-Google-Sender-Auth: lrygBWPj69TyYGuXRcHIAiHhKio Message-ID: Subject: Re: svn commit: r310425 - in head/sys/dev/mlx4: mlx4_core mlx4_ib To: Pedro Giffuni Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Dec 2016 20:56:09 -0000 On 22 December 2016 at 15:09, Pedro Giffuni wrote: > > On 22/12/2016 13:26, Ed Maste wrote: >> >> Author: emaste >> Date: Thu Dec 22 18:26:21 2016 >> New Revision: 310425 >> URL: https://svnweb.freebsd.org/changeset/base/310425 >> >> Log: >> mlx: avoid use of __DATE__ to make build reproducible >> Reviewed by: hselasky >> Differential Revision: https://reviews.freebsd.org/D8886 > > Hmm ... > Sadly opengrok[*] reveals many uses of __DATE__. Many of these are not an issue for a reproducible base system though: they're in comments, in source under tools/ or contrib code that's not built, or are the implementation of __DATE__ support in some compiler or text processor. I believe that on amd64 it was only this now-removed instance in mlx(4) and the one in iasl (see https://reviews.freebsd.org/D8856) that affected base system reproducibility. > I am wondering if there is some way to have it replaced with the SVN Date > keyword. I don't like the idea of deriving it from an SVN keyword, since it then doesn't work for FreeBSD developers or downstream projects using git or other version control tools. The kernel version uniquely identifies the source from which it was built, and in my opinion it's preferable to just remove this sort of metadata. Here I went with just pinning it to the last date the src was updated as this vendor code and produces a user-facing string, but perhaps Mellanox can be convinced to just remove the DRV_RELDATE. Posted in https://reviews.freebsd.org/D8888.