From owner-freebsd-bugs@FreeBSD.ORG  Sat Nov 17 11:10:11 2007
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 347FC16A41A;
	Sat, 17 Nov 2007 11:10:11 +0000 (UTC)
	(envelope-from dada@sbox.tugraz.at)
Received: from mailrelay.tugraz.at (mailrelay.tu-graz.ac.at [129.27.2.202])
	by mx1.freebsd.org (Postfix) with ESMTP id 5C7D613C4E3;
	Sat, 17 Nov 2007 11:10:09 +0000 (UTC)
	(envelope-from dada@sbox.tugraz.at)
Received: from webmail.tugraz.at (webmail.tu-graz.ac.at [129.27.2.204])
	by mailrelay2.tugraz.at (8.14.1/8.14.1) with ESMTP id lAHATBoT018370;
	Sat, 17 Nov 2007 11:29:11 +0100 (CET)
Received: from ARHA07.KFUNIGRAZ.AC.AT (ARHA07.KFUNIGRAZ.AC.AT
	[143.50.252.114]) by webmail.tugraz.at (Horde Framework) with HTTP;
	Sat, 17 Nov 2007 11:29:10 +0100
Message-ID: <20071117112910.156623xlukumke4k@webmail.tugraz.at>
X-Priority: 3 (Normal)
Date: Sat, 17 Nov 2007 11:29:10 +0100
From: Martin Kammerhofer <dada@sbox.tugraz.at>
To: kmacy@FreeBSD.org
References: <200711161700.lAGH0Fqg021324@freefall.freebsd.org>
In-Reply-To: <200711161700.lAGH0Fqg021324@freefall.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
	charset=UTF-8;
	DelSp="Yes";
	format="flowed"
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
User-Agent: Internet Messaging Program (IMP) H3 (4.2-cvs)
X-Organization: Graz University of Technology
X-Originating-IP: 143.50.252.114
X-Remote-Browser: Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 5.1; .NET
	CLR 1.1.4322; .NET CLR 1.0.3705; .NET CLR 2.0.50727; InfoPath.1;
	.NET CLR 3.0.04506.30)
X-Spam-Scanner: SpamAssassin 3.002003 
X-Spam-Score-relay: -4.4
X-Scanned-By: MIMEDefang 2.63 on 129.27.10.19
Cc: alc@FreeBSD.org, freebsd-bugs@FreeBSD.org
Subject: Re: kern/71258: [vm] [patch] anonymous mmappings not always page
	aligned
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 17 Nov 2007 11:10:11 -0000

Quoting kmacy@FreeBSD.org:

>
> Please comment on whether or not it is worth updating the docs
> or this is just blatant pilot error.
>

Either the code should be changed to ignore the MAP_ANON offset as the manpage
currently says, or - simpler solution - the manpage should state, that for
anonymous mappings the offset must be aligned to the page size.
This would bring the manpage in line with the specs; modulo the fact that
illegal offsets cause "undefined behaviour" rather than failing with EINVAL.

Relying on the current manpage wording a programmer _might_ try to save a few
cycles by e.g. passing an uninitialized offset variable. (This is rather
unlikely, but nevertheless having precise manpages is always a good thing.)

  Martin