From owner-freebsd-bugs@FreeBSD.ORG Fri Apr 30 15:10:04 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id BC1741065673 for ; Fri, 30 Apr 2010 15:10:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id 7F3588FC13 for ; Fri, 30 Apr 2010 15:10:04 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o3UFA40u029559 for ; Fri, 30 Apr 2010 15:10:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o3UFA4Gn029556; Fri, 30 Apr 2010 15:10:04 GMT (envelope-from gnats) Resent-Date: Fri, 30 Apr 2010 15:10:04 GMT Resent-Message-Id: <201004301510.o3UFA4Gn029556@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dmitry Marakasov Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 525791065674 for ; Fri, 30 Apr 2010 15:08:59 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from smtp.timeweb.ru (smtp.timeweb.ru [92.53.116.15]) by mx1.freebsd.org (Postfix) with ESMTP id 0F35B8FC18 for ; Fri, 30 Apr 2010 15:08:58 +0000 (UTC) Received: from [213.148.20.85] (helo=hive.panopticon) by smtp.timeweb.ru with esmtpsa (TLSv1:CAMELLIA256-SHA:256) (Exim 4.71) (envelope-from ) id 1O7rpo-0006Mq-GX; Fri, 30 Apr 2010 19:08:57 +0400 Received: from hades.panopticon (hades.panopticon [192.168.0.32]) by hive.panopticon (Postfix) with ESMTP id 1A331B856; Fri, 30 Apr 2010 19:08:56 +0400 (MSD) Received: by hades.panopticon (Postfix, from userid 1000) id 06512B829; Fri, 30 Apr 2010 19:08:56 +0400 (MSD) Message-Id: <20100430150856.06512B829@hades.panopticon> Date: Fri, 30 Apr 2010 19:08:56 +0400 (MSD) From: Dmitry Marakasov To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: ed@FreeBSD.org Subject: bin/146189: /usr/bin/script broken in HEAD and 8-STABLE X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Dmitry Marakasov List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Apr 2010 15:10:04 -0000 >Number: 146189 >Category: bin >Synopsis: /usr/bin/script broken in HEAD and 8-STABLE >Confidential: no >Severity: critical >Priority: high >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Apr 30 15:10:04 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Dmitry Marakasov >Release: FreeBSD 8.0-RELEASE i386 >Organization: >Environment: System: FreeBSD hades.panopticon 8.0-RELEASE FreeBSD 8.0-RELEASE #0: Tue Nov 24 22:31:59 MSK 2009 root@hades.panopticon:/async/obj/usr/src/sys/HADES i386 (but the PR applies to CURRENT and 8-STABLE) >Description: /usr/bin/script is broken in HEAD by r205008, in 8-STABLE by 205635. After these changes it no longer exits with the same exit code as the command it runs (thus, if the command fails, it'll still exit with 0) Among other things, this breaks portupgrade, as it now mistakingly interprets failed port builds as successfull ones, thus removing ports without installing newer versions. >How-To-Repeat: /usr/bin/script from r205007 # script -q /dev/null true; echo $? 0 # script -q /dev/null false; echo $? 1 /usr/bin/script from r205008 # script -q /dev/null true; echo $? 0 # script -q /dev/null false; echo $? 0 >Fix: >Release-Note: >Audit-Trail: >Unformatted: