Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 30 Apr 2010 19:08:56 +0400 (MSD)
From:      Dmitry Marakasov <amdmi3@FreeBSD.org>
To:        FreeBSD-gnats-submit@FreeBSD.org
Cc:        ed@FreeBSD.org
Subject:   bin/146189: /usr/bin/script broken in HEAD and 8-STABLE
Message-ID:  <20100430150856.06512B829@hades.panopticon>
Resent-Message-ID: <201004301510.o3UFA4Gn029556@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         146189
>Category:       bin
>Synopsis:       /usr/bin/script broken in HEAD and 8-STABLE
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Apr 30 15:10:04 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Dmitry Marakasov
>Release:        FreeBSD 8.0-RELEASE i386
>Organization:
>Environment:
System: FreeBSD hades.panopticon 8.0-RELEASE FreeBSD 8.0-RELEASE #0: Tue Nov 24 22:31:59 MSK 2009 root@hades.panopticon:/async/obj/usr/src/sys/HADES i386

(but the PR applies to CURRENT and 8-STABLE)

>Description:
/usr/bin/script is broken in HEAD by r205008, in 8-STABLE by 205635.

After these changes it no longer exits with the same exit code as the command it runs (thus, if the command fails, it'll still exit with 0)
Among other things, this breaks portupgrade, as it now mistakingly interprets failed port builds as successfull ones, thus removing ports without installing newer versions.

>How-To-Repeat:
/usr/bin/script from r205007
# script -q /dev/null true; echo $?
0
# script -q /dev/null false; echo $?
1

/usr/bin/script from r205008
# script -q /dev/null true; echo $? 
0
# script -q /dev/null false; echo $?
0

>Fix:

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100430150856.06512B829>