From owner-cvs-all@FreeBSD.ORG Wed Oct 31 22:29:28 2007 Return-Path: Delivered-To: cvs-all@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CFDDE16A420; Wed, 31 Oct 2007 22:29:28 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id 4216913C4AC; Wed, 31 Oct 2007 22:29:28 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.1/8.14.1) with ESMTP id l9VMNgc0090894; Thu, 1 Nov 2007 01:23:42 +0300 (MSK) (envelope-from ache@nagual.pp.ru) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nagual.pp.ru; s=default; t=1193869422; bh=24P2qltQCgHIdRPT17iuX0FkTtEgQsSHw9apIk5 qV8Y=; l=1121; h=Date:From:To:Cc:Subject:Message-ID: Mail-Followup-To:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To:User-Agent; b=FJpeQwT9XMXtvhJeXn4H j2foMt4zU+9V3yxNRxlBDdQ/Q6gsGG7XHF0Wrd9bMHD5j411ef3pcmtUoFTqYBZOCUa bfaKirinoSZg6PckFSd5SZBoz1W6Io0WkttqTpykBW74mKjFNPUFuOb4C7zQpB70XBZ c3eNUYc7UTwegvGwM= Received: (from ache@localhost) by nagual.pp.ru (8.14.1/8.14.1/Submit) id l9VMNfZU090893; Thu, 1 Nov 2007 01:23:41 +0300 (MSK) (envelope-from ache) Date: Thu, 1 Nov 2007 01:23:41 +0300 From: Andrey Chernov To: Alexey Dokuchaev Message-ID: <20071031222341.GB90781@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Alexey Dokuchaev , Christoph Mallon , cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200710272232.l9RMWSbK072082@repoman.freebsd.org> <47264710.2000500@gmx.de> <20071030064446.GC68358@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071030064446.GC68358@FreeBSD.org> User-Agent: Mutt/1.5.16 (2007-06-09) Cc: cvs-src@FreeBSD.ORG, Christoph Mallon , src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/include _ctype.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Oct 2007 22:29:28 -0000 On Tue, Oct 30, 2007 at 06:44:46AM +0000, Alexey Dokuchaev wrote: > On Mon, Oct 29, 2007 at 09:48:16PM +0100, Christoph Mallon wrote: > > Andrey A. Chernov wrote: > > >ache 2007-10-27 22:32:28 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > include _ctype.h > > > Log: > > > Micro-optimization of prev. commit, change > > > (_c < 0 || _c >= 128) to (_c & ~0x7F) > > > > > > Revision Changes Path > > > 1.33 +1 -1 src/include/_ctype.h > > > > Further IMO it is hard to decipher what _c & ~0x7F is supposed to do. > > Seconded. Messing with bits should be avoided when their use masks out > the logic behind. Nowadays it's almost always better to trust the > compiler to do its optimizing job. I just want to keep all ctype in style, and it comes from is{w}ascii(). Do you want rewrite is{w}ascii() to non-optimized case? Note that non-optimized case generate very long code when no optimization used in compiler which may happens in some cases (like avoiding gcc optimization bugs etc.) -- http://ache.pp.ru/