Date: Sun, 22 Sep 2019 22:58:27 +0000 From: bugzilla-noreply@freebsd.org To: gecko@FreeBSD.org Subject: [Bug 240686] security/nss: regressions tests require bash Message-ID: <bug-240686-21738-8huIFb3FMC@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-240686-21738@https.bugs.freebsd.org/bugzilla/> References: <bug-240686-21738@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D240686 Jan Beich <jbeich@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207626| |maintainer-approval+ Flags| | --- Comment #1 from Jan Beich <jbeich@FreeBSD.org> --- Comment on attachment 207626 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D207626 Run regression tests with bash Looks OK but see comments below. Bash'isms appear to have been introduced recently. Kinda sad as FreeBSD sh is blazingly fast while tests take a lot = of time due to lack of parallelism. > +TEST_DEPENDS=3D bash:shells/bash For "make test" to install the dependency convert "check regression-test te= st" (multi-name target) to "do-test". When tinderbox was in use by the package cluster (pointyhat at the time) "regression-test" was used and TEST_DEPENDS= was handled by tinderbox itself rather than the ports framework. > + ${LOCALBASE}/bin/bash ./all.sh Consistently use either "bash" or "${LOCALBASE}/bin/bash". I'd probably cho= ose the former unless there's a good reason to ignore PATH. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-240686-21738-8huIFb3FMC>