From owner-svn-src-all@FreeBSD.ORG Sun Jan 22 12:49:43 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 741DE106566B; Sun, 22 Jan 2012 12:49:43 +0000 (UTC) (envelope-from to.my.trociny@gmail.com) Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id F2EA88FC0A; Sun, 22 Jan 2012 12:49:41 +0000 (UTC) Received: by bkbc12 with SMTP id c12so2235021bkb.13 for ; Sun, 22 Jan 2012 04:49:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:references:x-comment-to:sender:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=0P77k/Zclchz1rZwRfXo4crCI5LFqvub1CeeF8WCRiU=; b=ju0G/fFQifYk6++6lpBhen23OkKu576seArDDzItbO0nhGWBWbVQyuV12RN/hOHn2X 6T7PubxbwRzAq1AKrmgiKpiV3QxSntKdaGrvv2rMI7W5dBroQylIWTfUQJI09q9gQ8qP PSJO4lTKqvEqG/4GsPNOxLuqtRoQHXGdEjSsk= Received: by 10.205.122.134 with SMTP id gg6mr1746211bkc.41.1327236581025; Sun, 22 Jan 2012 04:49:41 -0800 (PST) Received: from localhost ([95.69.173.122]) by mx.google.com with ESMTPS id fg16sm20597026bkb.16.2012.01.22.04.49.38 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 22 Jan 2012 04:49:39 -0800 (PST) From: Mikolaj Golub To: Jaakko Heinonen References: <201201170125.q0H1PrlJ061058@svn.freebsd.org> <20120117171031.GA2316@a91-153-116-96.elisa-laajakaista.fi> X-Comment-To: Jaakko Heinonen Sender: Mikolaj Golub Date: Sun, 22 Jan 2012 14:49:36 +0200 In-Reply-To: <20120117171031.GA2316@a91-153-116-96.elisa-laajakaista.fi> (Jaakko Heinonen's message of "Tue, 17 Jan 2012 19:10:31 +0200") Message-ID: <86obtvvr4v.fsf@kopusha.home.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: svn-src-head@freebsd.org, Kevin Lo , svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r230252 - head/sys/fs/tmpfs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Jan 2012 12:49:43 -0000 On Tue, 17 Jan 2012 19:10:31 +0200 Jaakko Heinonen wrote: JH> On 2012-01-17, Kevin Lo wrote: >> Return EOPNOTSUPP since we only support update mounts for NFS export. >> >> @@ -150,8 +150,12 @@ tmpfs_mount(struct mount *mp) >> return (EINVAL); >> >> if (mp->mnt_flag & MNT_UPDATE) { >> + /* >> + * Only support update mounts for NFS export. >> + */ >> if (vfs_flagopt(mp->mnt_optnew, "export", NULL, 0)) >> return (0); >> + return (EOPNOTSUPP); >> } JH> This doesn't look correct. As long as the option list includes the JH> "export" option, all options are accepted. An example: JH> # mount -u -o ro /mnt JH> mount: tmpfs : Operation not supported JH> # mount -u -o ro,export /mnt JH> # There is no error but ro is still ignored, so this is only the issue with reporting. Note, the code for nullfs (as an example) looks the same. It could be fixed with vfs_filteropt(9), not sure if this is worth doing here though. -- Mikolaj Golub