From nobody Thu Sep 11 16:57:26 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cN3dj2LlWz66vqS for ; Thu, 11 Sep 2025 16:57:45 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cN3dj0GbPz3TH8 for ; Thu, 11 Sep 2025 16:57:45 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pj1-x102d.google.com with SMTP id 98e67ed59e1d1-32de2f8562aso219684a91.1 for ; Thu, 11 Sep 2025 09:57:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1757609858; x=1758214658; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0H793k325/i6ztrh5q9U52l/kF+m8w7eJ0fk4C1Iydk=; b=pGIWgsBzAnvvYMwLSous4FTDyk4QlI+PgyvTpg14ELxQZbSZj2alPyRQxa7fgMNStB +Ep/qFFdq5vBljsfePiRS0Wumi4bS4cab3p1MyN+bIq77QsNN7fKPVjyCyaxpWJUDK2U D1mttVqEkUxP1iS5+HbAmRLoInGEJvU4acRY73y7l6zAybiydw+BJTk4mpH0DUkKXnn2 J0Tj9aijMQepJm/7d6liw9RTbIgzR6E/MN0HESkY6weUOS1HNJ5FsXPBZW34amiatHss FkNfcLj2UvsvnzUQV7+5GUfRIEVc1TJ7E55X7Z1+7JemqQ7uN/u096fxRVBzZh3Wge9G bdqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757609858; x=1758214658; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0H793k325/i6ztrh5q9U52l/kF+m8w7eJ0fk4C1Iydk=; b=NkCrotiFI2XiIuzcQVBCt4MDZrf0kCRnO7UzoSyBnwjoIxX4jyttRrsNIs9TGI0SUp KXdRqnuFeIF892IwBBfFT8YbXy4iKWvaNg0VFakfPOWpr+7lOgJxMkV49JQi310zXKrS pXNj1bQ/DfiAHKMK2nJY69thxW0yu6ltA+4eYeNoIDL81BzrEBSkKCitNxm5wnXlSRev OMOgVVtQd5qbv+xwelH96SeDhyfTVmrMPlJmI/Ca5DALgVe24yENjyU8IjS9wE7p0vcg taoArPYo7QXhWJ0y2e6e8qzCIXMGM0y19PeY2Kx50owawcALth0UO34HohcbEsBaUUfW drOg== X-Forwarded-Encrypted: i=1; AJvYcCUjXyViFw24DEcGBgPs0Wf1CLV9iWwA45CieKS/fdjKLolx7DaAj1yISwXljxp4Wjq/7mGGb7F2zCAJuKwyqYL0MNhz@freebsd.org X-Gm-Message-State: AOJu0Yynl4I0hrxcuO/zTKMyYD3MNTnC9yiyIJQibtBf3hKfMv4ZxGVC xss9LfUJQQx2dtZdU/WwNmUcLDAPY2HflFIIFjxpaAP0t4b7077oc34agwgfOKOogqL87CUwhY6 +RBrQqHoZsC9yniByqGOj2F0zqW5NvFfRD2LoAduXdA== X-Gm-Gg: ASbGncvrkET/kxX8qPupSXbLtt0XQyu620r2pw3w/PKYLpnrqtiBGoQ1rcsxqCIkxru MShR7diDka1iO58Xqda0SlGTIJjZ7xqQV0oz78ul1HYZuYa9bNVSVq4Zi9pM4jey+0BtijyKsdQ VRbEbIy2EBVu8Es7XE25YwonawMeM79Kmm733gnr0qlkZCIhi2hdEz7EJJEbA2XnSRJvLYqifzF Adp3DoAP5aDNnD2LVgxA6ps1S8vVtyIjvpQ3KIAoJt+90rcBA== X-Google-Smtp-Source: AGHT+IGdpG1h5OQCQDdeVupiiCOiu1spl5/V4iMKttT81PXz9akjJMIopzoMaBwi8XRmyagdcIpghjm+80IuMgRoP6c= X-Received: by 2002:a17:90b:2788:b0:329:ca48:7090 with SMTP id 98e67ed59e1d1-32d440df06fmr27278840a91.37.1757609857577; Thu, 11 Sep 2025 09:57:37 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <202509111512.58BFCV87088340@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Thu, 11 Sep 2025 10:57:26 -0600 X-Gm-Features: Ac12FXx-SxD5zvNhJKSoQ7Z-wa9vCsVbuDBf2S5KrOyFSl2ilxaaLA8hEIp-pI8 Message-ID: Subject: Re: git: d20c82507278 - main - Revert "libc: Remove readdir_r(3)" To: =?UTF-8?Q?Olivier_Cochard=2DLabb=C3=A9?= Cc: =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="0000000000003702fc063e896f1f" X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4cN3dj0GbPz3TH8 --0000000000003702fc063e896f1f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Sep 11, 2025 at 10:27=E2=80=AFAM Olivier Cochard-Labb=C3=A9 wrote: > > On Thu, Sep 11, 2025 at 8:12=E2=80=AFAM Dag-Erling Sm=C3=B8rgrav > wrote: > >> The branch main has been updated by des: >> >> URL: >> https://cgit.FreeBSD.org/src/commit/?id=3Dd20c82507278e003f391c3fb04f4e4= 9afd1537ab >> >> commit d20c82507278e003f391c3fb04f4e49afd1537ab >> Author: Dag-Erling Sm=C3=B8rgrav >> AuthorDate: 2025-09-11 15:12:22 +0000 >> Commit: Dag-Erling Sm=C3=B8rgrav >> CommitDate: 2025-09-11 15:12:22 +0000 >> >> Revert "libc: Remove readdir_r(3)" >> >> This reverts commit d549de769055ae6116601e54e4c86dfb3e17f4c4. >> >> > Hi Dag-Erling, > Could you please explain why this change was reversed? > Because the reason was missing from this commit message. > Rust breaks with this change. While rust can be fixed (and will be) since it's doing some sketch things and the fix is to just remove the sketch stuff. However, part of Rust's work flow is to do A/B testing between new runs under test, and older Rust versions. The old binaries work fine, but newly-built copies of the old versions do not. Until those old versions 'age out' of this setup, we'll be stuck with this. Warner --0000000000003702fc063e896f1f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Thu, Sep 11,= 2025 at 10:27=E2=80=AFAM Olivier Cochard-Labb=C3=A9 <olivier@freebsd.org> wrote:
<= div style=3D"font-family:"courier new",monospace">
On Thu, S= ep 11, 2025 at 8:12=E2=80=AFAM Dag-Erling Sm=C3=B8rgrav <des@freebsd.org> wrote:
The branch main has be= en updated by des:

URL: https://cgit.= FreeBSD.org/src/commit/?id=3Dd20c82507278e003f391c3fb04f4e49afd1537ab
commit d20c82507278e003f391c3fb04f4e49afd1537ab
Author:=C2=A0 =C2=A0 =C2=A0Dag-Erling Sm=C3=B8rgrav <des@FreeBSD.org>=
AuthorDate: 2025-09-11 15:12:22 +0000
Commit:=C2=A0 =C2=A0 =C2=A0Dag-Erling Sm=C3=B8rgrav <des@FreeBSD.org>=
CommitDate: 2025-09-11 15:12:22 +0000

=C2=A0 =C2=A0 Revert "libc: Remove readdir_r(3)"

=C2=A0 =C2=A0 This reverts commit d549de769055ae6116601e54e4c86dfb3e17f4c4.=


Hi Dag-Erling,
Could you please expl= ain why this change was reversed?
Because the reason was missing from th= is commit message.

Rust bre= aks with this change. While rust can be fixed (and will be) since it's = doing some sketch things and the fix is to just remove the sketch stuff. Ho= wever, part of Rust's work flow is to do A/B testing between new runs u= nder test, and older Rust versions. The old binaries work fine, but newly-b= uilt copies of the old versions do not. Until those old versions 'age o= ut' of this setup, we'll be stuck with this.

Warner=C2=A0
--0000000000003702fc063e896f1f--