From owner-freebsd-current@freebsd.org Tue Mar 21 02:40:50 2017 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 185C7D15030 for ; Tue, 21 Mar 2017 02:40:50 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-QB1-obe.outbound.protection.outlook.com (mail-eopbgr660079.outbound.protection.outlook.com [40.107.66.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "Microsoft IT SSL SHA2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B25221C8C; Tue, 21 Mar 2017 02:40:49 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from YTXPR01MB0189.CANPRD01.PROD.OUTLOOK.COM (10.165.218.133) by YTXPR01MB0190.CANPRD01.PROD.OUTLOOK.COM (10.165.218.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.977.11; Tue, 21 Mar 2017 02:40:47 +0000 Received: from YTXPR01MB0189.CANPRD01.PROD.OUTLOOK.COM ([10.165.218.133]) by YTXPR01MB0189.CANPRD01.PROD.OUTLOOK.COM ([10.165.218.133]) with mapi id 15.01.0977.019; Tue, 21 Mar 2017 02:40:46 +0000 From: Rick Macklem To: Gergely Czuczy , Konstantin Belousov CC: Dimitry Andric , Ian Lepore , "FreeBSD Current" Subject: Re: process killed: text file modification Thread-Topic: process killed: text file modification Thread-Index: AQHSnqPLfXcZwdtVHkecT5jK6Yv9dKGYQJIXgAAZ/baAAFsxgIAAVqF+gAAJQ4CAAFvPgIAAF1PPgABnggCAArMZZIAAClcAgAHrwIA= Date: Tue, 21 Mar 2017 02:40:46 +0000 Message-ID: References: <5ac94b9a-7ced-9eff-d746-7dddaaeca516@harmless.hu> <1489340839.40576.82.camel@freebsd.org> <20170317083605.GQ16105@kib.kiev.ua> <20170317141917.GS16105@kib.kiev.ua> <20170318032150.GW16105@kib.kiev.ua> , <4642046a-08e6-35af-c76e-c5e306f01e62@harmless.hu> In-Reply-To: <4642046a-08e6-35af-c76e-c5e306f01e62@harmless.hu> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: authentication-results: FreeBSD.org; dkim=none (message not signed) header.d=none;FreeBSD.org; dmarc=none action=none header.from=uoguelph.ca; x-microsoft-exchange-diagnostics: 1; YTXPR01MB0190; 7:h0VuMPScvhoJXuzNjdeDJ3ilq3TBoIGsUzzTrLgv8Ei7uPGe688CvveJyEB+ElGh3U7lKw+4CaJdVSPugWSV7nKaPIDltaiXILiE0xj3P4uB5FX/v9SyebFc/1z7ifmpSxBk9GDIJjLulqCTFGkFqXWJrFBrgxACowMnU/4spWYsFlM3BC8svOdWhAa3ok5Y+cywJT4y6qSs7DUvcZA/YTmmFNo0hlKtisWmz8tC5BDn6zqQAiPn4p3376eb78aaoo7K9E1iVzNnydVxhP6rGVvEZd6UQ4tnIZAmWKAkAdzKyAm0Wz+Lr4s2f9pJEI7FE/Qu+zvq6umPnsiBqh01VA== x-ms-office365-filtering-correlation-id: ef8128bf-3321-406d-2750-08d47003add9 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075); SRVR:YTXPR01MB0190; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(102415395)(6040375)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6041248)(20161123558025)(20161123560025)(20161123555025)(20161123562025)(20161123564025)(6072148); SRVR:YTXPR01MB0190; BCL:0; PCL:0; RULEID:; SRVR:YTXPR01MB0190; x-forefront-prvs: 02530BD3AA x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39450400003)(24454002)(51874003)(86362001)(305945005)(2906002)(3280700002)(3660700001)(74316002)(2950100002)(99936001)(38730400002)(50986999)(6246003)(76176999)(54356999)(2900100001)(6436002)(5660300001)(7696004)(33656002)(6506006)(93886004)(77096006)(74482002)(53936002)(9686003)(54906002)(55016002)(122556002)(229853002)(81166006)(8936002)(8676002)(5890100001)(4326008)(39060400002)(189998001)(102836003); DIR:OUT; SFP:1101; SCL:1; SRVR:YTXPR01MB0190; H:YTXPR01MB0189.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; MLV:ovrnspm; PTR:InfoNoRecords; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: multipart/mixed; boundary="_002_YTXPR01MB01891633D0486547C3E748E3DD3D0YTXPR01MB0189CANP_" MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Mar 2017 02:40:46.8734 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-Transport-CrossTenantHeadersStamped: YTXPR01MB0190 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Mar 2017 02:40:50 -0000 --_002_YTXPR01MB01891633D0486547C3E748E3DD3D0YTXPR01MB0189CANP_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Gergely Czuczy wrote: [stuff snipped] > Actually I want to test it, but you guys are so vehemently discussing > it, I thought it would be better to do so, once you guys settled your > analysis on the code. Also, me not having the problem occurring, I don't > think would mean it's solved, since that would only mean, the codepath > for my specific usecase works. There might be other things there as > well, what I don't hit. I hope by vehemently, you didn't find my comments as nasty. If they did come out that way, it was not what I intended and I apologize. > Let me know which patch should I test, and I will see to it in the next > couple of days, when I get the time to do it. I've attached it here again and, yes, I would agree that the results you ge= t from testing are just another data point and not definitive.=20 (I'd say this statement is true of all testing of nontrivial code.) Thanks in advance for any testing you can do, rick --_002_YTXPR01MB01891633D0486547C3E748E3DD3D0YTXPR01MB0189CANP_ Content-Type: application/octet-stream; name="textmod.patch" Content-Description: textmod.patch Content-Disposition: attachment; filename="textmod.patch"; size=1343; creation-date="Tue, 21 Mar 2017 02:39:56 GMT"; modification-date="Tue, 21 Mar 2017 02:39:56 GMT" Content-Transfer-Encoding: base64 LS0tIGZzL25mc2NsaWVudC9uZnNfY2x2bm9wcy5jLnRleHQJMjAxNy0wMy0xNiAyMTo1NToxNi4y NjMzOTMwMDAgLTA0MDAKKysrIGZzL25mc2NsaWVudC9uZnNfY2x2bm9wcy5jCTIwMTctMDMtMTcg MDk6MzE6MjMuNjMyODE0MDAwIC0wNDAwCkBAIC0xNDAsNiArMTQwLDcgQEAgc3RhdGljIHZvcF9h ZHZsb2NrX3QJbmZzX2FkdmxvY2s7CiBzdGF0aWMgdm9wX2FkdmxvY2thc3luY190IG5mc19hZHZs b2NrYXN5bmM7CiBzdGF0aWMgdm9wX2dldGFjbF90IG5mc19nZXRhY2w7CiBzdGF0aWMgdm9wX3Nl dGFjbF90IG5mc19zZXRhY2w7CitzdGF0aWMgdm9wX3NldF90ZXh0X3QgbmZzX3NldF90ZXh0Owog CiAvKgogICogR2xvYmFsIHZmcyBkYXRhIHN0cnVjdHVyZXMgZm9yIG5mcwpAQCAtMTc2LDYgKzE3 Nyw3IEBAIHN0cnVjdCB2b3BfdmVjdG9yIG5ld25mc192bm9kZW9wcyA9IHsKIAkudm9wX3dyaXRl ID0JCW5jbF93cml0ZSwKIAkudm9wX2dldGFjbCA9CQluZnNfZ2V0YWNsLAogCS52b3Bfc2V0YWNs ID0JCW5mc19zZXRhY2wsCisJLnZvcF9zZXRfdGV4dCA9CQluZnNfc2V0X3RleHQsCiB9OwogCiBz dHJ1Y3Qgdm9wX3ZlY3RvciBuZXduZnNfZmlmb29wcyA9IHsKQEAgLTMzNzMsNiArMzM3NSwyOSBA QCBuZnNfc2V0YWNsKHN0cnVjdCB2b3Bfc2V0YWNsX2FyZ3MgKmFwKQogCXJldHVybiAoZXJyb3Ip OwogfQogCitzdGF0aWMgaW50CituZnNfc2V0X3RleHQoc3RydWN0IHZvcF9zZXRfdGV4dF9hcmdz ICphcCkKK3sKKwlzdHJ1Y3Qgdm5vZGUgKnZwID0gYXAtPmFfdnA7CisJc3RydWN0IG5mc25vZGUg Km5wOworCisJLyoKKwkgKiBJZiB0aGUgdGV4dCBmaWxlIGhhcyBiZWVuIG1tYXAnZCwgdGhlIGRp cnR5IHBhZ2VzIG11c3QgYmUgZmx1c2hlZAorCSAqIHNvIHRoYXQgdGhlIG1vZGlmeSB0aW1lIG9m IHRoZSBmaWxlIHdpbGwgYmUgdXAgdG8gZGF0ZS4KKwkgKi8KKwlpZiAodnAtPnZfb2JqZWN0ICE9 IE5VTEwpIHsKKwkJbnAgPSBWVE9ORlModnApOworCQlWTV9PQkpFQ1RfV0xPQ0sodnAtPnZfb2Jq ZWN0KTsKKwkJdm1fb2JqZWN0X3BhZ2VfY2xlYW4odnAtPnZfb2JqZWN0LCAwLCAwLCBPQkpQQ19T WU5DKTsKKwkJVk1fT0JKRUNUX1dVTkxPQ0sodnAtPnZfb2JqZWN0KTsKKwkJbXR4X2xvY2soJm5w LT5uX210eCk7CisJCW5wLT5uX210aW1lID0gbnAtPm5fdmF0dHIubmFfbXRpbWU7CisJCW10eF91 bmxvY2soJm5wLT5uX210eCk7CisJfQorCXZwLT52X3ZmbGFnIHw9IFZWX1RFWFQ7CisJcmV0dXJu ICgwKTsKK30KKwogLyoKICAqIFJldHVybiBQT1NJWCBwYXRoY29uZiBpbmZvcm1hdGlvbiBhcHBs aWNhYmxlIHRvIG5mcyBmaWxlc3lzdGVtcy4KICAqLwo= --_002_YTXPR01MB01891633D0486547C3E748E3DD3D0YTXPR01MB0189CANP_--