Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 9 Oct 2012 11:12:34 GMT
From:      Ildar Hizbulin <hizel@vyborg.ru>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/172552: [PATCH] multimedia/motion bktr driver not work after ports/169006
Message-ID:  <201210091112.q99BCYD7038523@red.freebsd.org>
Resent-Message-ID: <201210092230.q99MUSHg043736@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         172552
>Category:       ports
>Synopsis:       [PATCH] multimedia/motion bktr driver not work after ports/169006
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Oct 09 22:30:27 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Ildar Hizbulin
>Release:        8.0-STABLE
>Organization:
Ariadna-Link, JSC
>Environment:
FreeBSD gg.vyborg.ru 8.0-STABLE FreeBSD 8.0-STABLE #5: Fri Dec  4 15:22:18 MSK 2009     root@gg.vyborg.ru:/usr/obj/usr/src/sys/GG  i386
>Description:
After ports/169006 changes port with BKTR option and without PWCBSD option build with parameter -DWITHOUT_V4L. But this WITHOUT_V4L parameter disable all video input BKTR and PWCBSD. The user sees: "You must setup netcam_url" like this http://www.lavrsen.dk/foswiki/bin/view/Motion/BugReport2012x07x27x023750 . Look code: https://github.com/sackmotion/motion/blob/master/video_freebsd.c#L1064 .

>How-To-Repeat:
build port multimedia/motion with video capture BKTR and without PWCBSD
>Fix:


Patch attached with submission follows:

diff -ruN multimedia/motion.old/Makefile multimedia/motion/Makefile
--- multimedia/motion.old/Makefile	2012-10-09 09:29:28.000000000 +0400
+++ multimedia/motion/Makefile	2012-10-09 10:55:09.000000000 +0400
@@ -7,6 +7,7 @@
 
 PORTNAME=	motion
 PORTVERSION=	3.2.12
+PORTREVISION=	1
 CATEGORIES=	multimedia
 MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}%20-%20${PORTVERSION:R}/${PORTVERSION}
 
@@ -53,6 +54,9 @@
 CONFIGURE_ARGS+=--with-pwcbsd
 .else
 CONFIGURE_ARGS+=--without-pwcbsd
+.endif
+
+.if !${PORT_OPTIONS:MBKTR} && !${PORT_OPTIONS:MPWCBSD}
 CFLAGS+=	-DWITHOUT_V4L
 .endif
 


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201210091112.q99BCYD7038523>