From nobody Sat Jun 20 10:55:20 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gjBFj10HSz6jKJD; Sat, 20 Jun 2026 10:55:37 +0000 (UTC) (envelope-from kib@freebsd.org) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4gjBFh4JV7z3Try; Sat, 20 Jun 2026 10:55:36 +0000 (UTC) (envelope-from kib@freebsd.org) Authentication-Results: mx1.freebsd.org; none Received: from tom.home (kib@localhost [127.0.0.1] (may be forged)) by kib.kiev.ua (8.18.1/8.18.1) with ESMTP id 65KAtKEY043165; Sat, 20 Jun 2026 13:55:23 +0300 (EEST) (envelope-from kib@freebsd.org) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 65KAtKEY043165 Received: (from kostik@localhost) by tom.home (8.18.1/8.18.1/Submit) id 65KAtK41043164; Sat, 20 Jun 2026 13:55:20 +0300 (EEST) (envelope-from kib@freebsd.org) X-Authentication-Warning: tom.home: kostik set sender to kib@freebsd.org using -f Date: Sat, 20 Jun 2026 13:55:20 +0300 From: Konstantin Belousov To: Warner Losh , alc@freebsd.org Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Faraz Vahedi Subject: Re: git: 9d87c1aac4a8 - main - libc: Add missing kill_dependency macro Message-ID: References: <6a35ddd4.24ba1.2ad9343d@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6a35ddd4.24ba1.2ad9343d@gitrepo.freebsd.org> X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=4.0.2 X-Spam-Checker-Version: SpamAssassin 4.0.2 (2025-08-27) on tom.home X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US] X-Rspamd-Queue-Id: 4gjBFh4JV7z3Try X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated On Sat, Jun 20, 2026 at 12:24:52AM +0000, Warner Losh wrote: > The branch main has been updated by imp: > > URL: https://cgit.FreeBSD.org/src/commit/?id=9d87c1aac4a84ac5e82acf872f645a7202977204 > > commit 9d87c1aac4a84ac5e82acf872f645a7202977204 > Author: Faraz Vahedi > AuthorDate: 2026-05-01 15:41:49 +0000 > Commit: Warner Losh > CommitDate: 2026-06-20 00:23:28 +0000 > > libc: Add missing kill_dependency macro > > Add `kill_dependency` as specified by C11 ยง7.17.3.1. > > The macro is required to break dependency chains in > expressions without affecting the value. > > No functional impact beyond providing the required, > value-preserving definition. > > Signed-off-by: Faraz Vahedi > Reviewed by: imp > Pull Request: https://github.com/freebsd/freebsd-src/pull/2185 > --- > sys/sys/stdatomic.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sys/sys/stdatomic.h b/sys/sys/stdatomic.h > index 2d565ce991be..e6eb46cd6ef3 100644 > --- a/sys/sys/stdatomic.h > +++ b/sys/sys/stdatomic.h > @@ -141,6 +141,8 @@ typedef enum { > memory_order_seq_cst = __ATOMIC_SEQ_CST > } memory_order; > > +#define kill_dependency(y) (y) > + GCC at least with the version 16 uses a different definition for the kill_dependency(), which might have some side effects for the gcc optimizers: #define kill_dependency(Y) \ __extension__ \ ({ \ __auto_type __kill_dependency_tmp = (Y); \ __kill_dependency_tmp; \ }) Since the semantic for kill_dependency() is believed to be not well defined, I think we should provide gcc-compliant definition at least for gcc.