From nobody Tue Jun 23 20:53:07 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4glHMm286Lz6j6RV for ; Tue, 23 Jun 2026 20:53:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4glHMl6n76z3HdX for ; Tue, 23 Jun 2026 20:53:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782247988; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bSJlqT9WI36vAYDxyMMuaIvK+0HpjqifAkHwO20Xq3Y=; b=DMRmfQOcZQuCsadRxs5kpdG2imeeeGzJykRW7TBLHnOfT8hfT4pWQCJ+S1U4+rQfzae6x4 0TdBkU9gPR14ieDrUBKxcQTFoeGhQoqvQfaeh/MchD5AeC89Z46cmZ1sMwd+28UD5L4BLo HsFLm2Kei+Dd7581wFF39mE9t93CEwZcEBFYet6tFsAfN80yMnAwvD8A4n7+atgI9p7ElA 3Q/98dDXjSBmgTNKu5sc15NrolXuBmupwPPVV+zUXVsLwYm6lyNkONa5psFkPRqm5HAL2i ADvR4H3aIskBTegOT6Pd4oESCqS+n2zABx/0BrUBXOxnTwHh6Ei9pLVLHxRoVg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782247988; a=rsa-sha256; cv=none; b=aOCw/xvF2nKwOKee4u31hT8beq9ONS3Cdv3wMjik3QyEn95JpMImnpspFkgdRCAkP++D2V ayQu2nok+gQDoBKO2dc+3IX1WdnuUCHOVQg2j8jYSzuiie0dsm39qPBvahOk4lpAspckvo NLI8IiAEV1RTdqZGzGrb8O8UO7jfE34poZlJS9Q9jBRWio4P+2l5xRN9AFzIrWF1+DsxRh SzSVLR0Ma8W2ceNnTAI1VOJRF69RUpLGQC8XkNMRMREoUJ/sHvna+IFxO8arz30jkfJS9I lrq7VMSNdDzWRRmezIIZygy9kj1tJcjPTwrguitCRELvDopGFREj0v+zz0i8lQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782247988; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bSJlqT9WI36vAYDxyMMuaIvK+0HpjqifAkHwO20Xq3Y=; b=PIy33/Vf54uDDQGJkPk2aQ/xy/wMq6NaIIj/+6ThkG3aScTSPThGi17XH++GitVPWQsjE3 lxBCkLFXJU1t4BtZvSN2TVdwgTMN9j2rT8fg8Cw1zLWPTwc8NRnGNE2CM8uFBhNv/oyuO5 2Q9PReRVjGDH/n63cJFlud3FxEtwyjcDdz6j2I76XLlTHN07iDphTQ29boL7aanym54wBE RvEgJvb+NNTtw7g9mxAHKXy+nLBSccdgh/M/9twEgxDsBK5HiIMhR9Y5ZotK/8mXrGP4vn 75VEP5rd9Gstq3uwC+pcwzLBxy4oxICnEwMZ6oOKdvx9vOWPAebC9zGiTJKvGg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4glHMl5SxHzqnF for ; Tue, 23 Jun 2026 20:53:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1a317 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 23 Jun 2026 20:53:07 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: ShengYi Hung Subject: git: 4f40c7c37fb4 - stable/15 - usb: Add missing mtx lock and unlock in pushing dma queue List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: aokblast X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 4f40c7c37fb458b6a5c494a28bd78aa1d66fa9a8 Auto-Submitted: auto-generated Date: Tue, 23 Jun 2026 20:53:07 +0000 Message-Id: <6a3af233.1a317.25fdff51@gitrepo.freebsd.org> The branch stable/15 has been updated by aokblast: URL: https://cgit.FreeBSD.org/src/commit/?id=4f40c7c37fb458b6a5c494a28bd78aa1d66fa9a8 commit 4f40c7c37fb458b6a5c494a28bd78aa1d66fa9a8 Author: ShengYi Hung AuthorDate: 2026-05-28 08:42:11 +0000 Commit: ShengYi Hung CommitDate: 2026-06-23 20:52:08 +0000 usb: Add missing mtx lock and unlock in pushing dma queue Accessing usb_xfer_queue requires bus lock, we added this missing lock in here to prevent racing issue. Reviewed by: adrian MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D57293 (cherry picked from commit df5e9e3da5b9b3fe63ed4aaaa19b824fd18ae0f2) --- sys/dev/usb/usb_transfer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/dev/usb/usb_transfer.c b/sys/dev/usb/usb_transfer.c index 67745cf49397..d41121ed3a06 100644 --- a/sys/dev/usb/usb_transfer.c +++ b/sys/dev/usb/usb_transfer.c @@ -1889,8 +1889,10 @@ usbd_transfer_submit(struct usb_xfer *xfer) */ #if USB_HAVE_BUSDMA if (xfer->flags_int.bdma_enable) { + USB_BUS_LOCK(bus); /* insert the USB transfer last in the BUS-DMA queue */ usb_command_wrapper(&xfer->xroot->dma_q, xfer); + USB_BUS_UNLOCK(bus); return; } #endif