From owner-svn-src-head@freebsd.org Fri Feb 14 09:29:28 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AE4F2244FAB; Fri, 14 Feb 2020 09:29:28 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com [209.85.219.171]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48Jp476d7yz4HZ2; Fri, 14 Feb 2020 09:29:27 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: by mail-yb1-f171.google.com with SMTP id j78so1027247ybg.12; Fri, 14 Feb 2020 01:29:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Z1jhfMlAPbZPjmVrTDXgt/CUO+0EHcsuNLVV8EwK2NI=; b=DcrmN5sYyUWN+kYNW6FyBZlE3C1GBHqMwLfIh3rjkbvEiQWOanHRAw6Dq1kjBWBwKD k82Dfj/z/ifcBljaOWrK17pxt7Jo40rUh3/97uuuKQYwApd3i1k+vzhpE9gANbDg5AiM 46hh/SOHFVILOehyMw2GLu2AkcS9HrGkdgZ3cm4pqGnenaOO456iET1TsHH7/E/C3Dxr N8IxsNPqNEtmITMleJw/CeX5Q/NGYIPCi2JwGKaFSG4CTUyqcDq//F9JKSr2WMcFMwxI EGoh0ETDdIsJm2TUkwZxoLl5DnUg3eu4jnYe03mJmo5xDlvC4qLo9+BPvrKGy5FY/DL8 BN8A== X-Gm-Message-State: APjAAAVrtyJ0wYzKoy1h52094iyZp6G5qUlb7mqezKGzev9VOVxPcQ22 2uvRJUo3UDedgX6liztmF5gW6t1JKE2rHbVLoWA= X-Google-Smtp-Source: APXvYqzSLb16eueQdfY0PKE9fWaQmL5w4YmZqMKLSvIjswxJTzrFIbFEKmPfajkqaTp0ReGQyFIcSHRSaDRJUzDtjJ4= X-Received: by 2002:a25:8452:: with SMTP id r18mr1772039ybm.176.1581672566506; Fri, 14 Feb 2020 01:29:26 -0800 (PST) MIME-Version: 1.0 References: <202002131905.01DJ5Ja6044695@repo.freebsd.org> <20200213213322.GL4808@kib.kiev.ua> In-Reply-To: <20200213213322.GL4808@kib.kiev.ua> From: Li-Wen Hsu Date: Fri, 14 Feb 2020 17:29:14 +0800 Message-ID: Subject: Re: svn commit: r357867 - head/tests/sys/net To: Konstantin Belousov Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 48Jp476d7yz4HZ2 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of lwhsufreebsd@gmail.com designates 209.85.219.171 as permitted sender) smtp.mailfrom=lwhsufreebsd@gmail.com X-Spamd-Result: default: False [-4.72 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[171.219.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-2.72)[ip: (-8.85), ipnet: 209.85.128.0/17(-3.01), asn: 15169(-1.68), country: US(-0.05)]; FORGED_SENDER(0.30)[lwhsu@freebsd.org,lwhsufreebsd@gmail.com]; FREEMAIL_TO(0.00)[gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[171.219.85.209.rep.mailspike.net : 127.0.0.17]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[lwhsu@freebsd.org,lwhsufreebsd@gmail.com]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Feb 2020 09:29:28 -0000 On Fri, Feb 14, 2020 at 5:33 AM Konstantin Belousov wrote: > On Thu, Feb 13, 2020 at 07:05:19PM +0000, Li-Wen Hsu wrote: > > -#define RANDOM_MAX ((1<<31) - 1) > > +#define RANDOM_MAX (((long)1<<31) - 1) > This still gives UB on ILP32 platforms. I believe the better fix would be > (1u << 31) - 1. Thanks for pointing this out. It is fixed this in r357904. Li-Wen