From owner-svn-src-all@FreeBSD.ORG Sun Oct 7 02:08:19 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id BE66D1065670; Sun, 7 Oct 2012 02:08:19 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id A8A5A8FC08; Sun, 7 Oct 2012 02:08:19 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q9728JH9091702; Sun, 7 Oct 2012 02:08:19 GMT (envelope-from imp@svn.freebsd.org) Received: (from imp@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id q9728JT7091700; Sun, 7 Oct 2012 02:08:19 GMT (envelope-from imp@svn.freebsd.org) Message-Id: <201210070208.q9728JT7091700@svn.freebsd.org> From: Warner Losh Date: Sun, 7 Oct 2012 02:08:19 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r241308 - head/sys/arm/at91 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Oct 2012 02:08:19 -0000 Author: imp Date: Sun Oct 7 02:08:19 2012 New Revision: 241308 URL: http://svn.freebsd.org/changeset/base/241308 Log: Improve a few comments. Modified: head/sys/arm/at91/at91_rtc.c Modified: head/sys/arm/at91/at91_rtc.c ============================================================================== --- head/sys/arm/at91/at91_rtc.c Sun Oct 7 01:58:32 2012 (r241307) +++ head/sys/arm/at91/at91_rtc.c Sun Oct 7 02:08:19 2012 (r241308) @@ -29,11 +29,13 @@ * * This driver does not currently support alarms, just date and time. * - * Note that on an rm9200 the RTC is not your typical battery-driven clock that - * keeps time while the system is powered down. In fact, it doesn't even - * survive a chip reset to keep time across a reboot. About the only thing it - * might be good for is keeping time while the cpu clock is turned off for power - * savings. On later chips, a battery backup feature is available. + * The RTC on the AT91RM9200 resets when the core rests, so it is useless as a + * source of time (except when the CPU clock is powered down to save power, + * which we don't currently do). On AT91SAM9 chips, the RTC survives chip + * reset, and there's provisions for it to keep time via battery backup if the + * system loses power. On those systems, we use it as a RTC. We tell the two + * apart because the century field is 19 on AT91RM9200 on reset, or on AT91SAM9 + * chips that haven't had their time properly set. */ #include @@ -186,10 +188,13 @@ out: return (err); } +/* + * Cannot support detach, since there's no clock_unregister function. + */ static int at91_rtc_detach(device_t dev) { - return (EBUSY); /* XXX */ + return (EBUSY); } static int