From owner-svn-src-all@FreeBSD.ORG Thu Feb 26 09:42:04 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 49514646; Thu, 26 Feb 2015 09:42:04 +0000 (UTC) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 350878C8; Thu, 26 Feb 2015 09:42:04 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.9/8.14.9) with ESMTP id t1Q9g41v089242; Thu, 26 Feb 2015 09:42:04 GMT (envelope-from kib@FreeBSD.org) Received: (from kib@localhost) by svn.freebsd.org (8.14.9/8.14.9/Submit) id t1Q9g4bv089241; Thu, 26 Feb 2015 09:42:04 GMT (envelope-from kib@FreeBSD.org) Message-Id: <201502260942.t1Q9g4bv089241@svn.freebsd.org> X-Authentication-Warning: svn.freebsd.org: kib set sender to kib@FreeBSD.org using -f From: Konstantin Belousov Date: Thu, 26 Feb 2015 09:42:04 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r279318 - head/lib/libstdthreads X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Feb 2015 09:42:04 -0000 Author: kib Date: Thu Feb 26 09:42:03 2015 New Revision: 279318 URL: https://svnweb.freebsd.org/changeset/base/279318 Log: Check that the pointer to the thread return value is not NULL before dereferencing. NULL is allowed by C11 and must be handled. Reported and tested by: Vineela PR: 198038 Sponsored by: The FreeBSD Foundation MFC after: 1 week Modified: head/lib/libstdthreads/thrd.c Modified: head/lib/libstdthreads/thrd.c ============================================================================== --- head/lib/libstdthreads/thrd.c Thu Feb 26 09:31:25 2015 (r279317) +++ head/lib/libstdthreads/thrd.c Thu Feb 26 09:42:03 2015 (r279318) @@ -108,7 +108,8 @@ thrd_join(thrd_t thr, int *res) if (pthread_join(thr, &value_ptr) != 0) return (thrd_error); - *res = (intptr_t)value_ptr; + if (res != NULL) + *res = (intptr_t)value_ptr; return (thrd_success); }