Date: Sun, 13 Mar 2011 14:15:28 +0100 From: Alexander Leidinger <Alexander@Leidinger.net> To: Artem Belevich <fbsdlist@src.cx> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Andriy Gapon <avg@freebsd.org> Subject: Re: svn commit: r219559 - in head/sys: amd64/linux32 compat/freebsd32 i386/linux kern Message-ID: <20110313141528.000013b1@unknown> In-Reply-To: <AANLkTimOAKLJm10dZAu2SYPeUk3agL_hsv-t7D1UHOj5@mail.gmail.com> References: <201103120851.p2C8phoN010341@svn.freebsd.org> <20110312205719.00004e67@unknown> <AANLkTimOAKLJm10dZAu2SYPeUk3agL_hsv-t7D1UHOj5@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 12 Mar 2011 22:24:09 -0800 Artem Belevich <fbsdlist@src.cx> wrote: > >> Modified: head/sys/i386/linux/syscalls.master > >> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 l_ha= ndler_t handler); } > >> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 void= *handler); } > > > > What's wrong with l_handler_t? >=20 > I don't recall the details, but I believe that the way l_handler_t is > defined resulted in compilation errors in generated glue code. Glue > generation code relies on '*' before the argument name in order to > tell scalars from pointers. l_handler_t was interpreted as a scalar > and on i386 where l_handler_t is a pointer, it produced compilation > warning. What about documenting it with a comment nearby? Bye, Alexander.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110313141528.000013b1>