From owner-svn-src-all@FreeBSD.ORG Sun Nov 23 21:54:41 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 56012762; Sun, 23 Nov 2014 21:54:41 +0000 (UTC) Received: from mho-02-ewr.mailhop.org (mho-02-ewr.mailhop.org [204.13.248.72]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 28CBCC5C; Sun, 23 Nov 2014 21:54:40 +0000 (UTC) Received: from [73.34.117.227] (helo=ilsoft.org) by mho-02-ewr.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.72) (envelope-from ) id 1Xsf74-000OJJ-5l; Sun, 23 Nov 2014 21:54:34 +0000 Received: from [172.22.42.240] (revolution.hippie.lan [172.22.42.240]) by ilsoft.org (8.14.9/8.14.9) with ESMTP id sANLsXNg009115; Sun, 23 Nov 2014 14:54:33 -0700 (MST) (envelope-from ian@FreeBSD.org) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 73.34.117.227 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX18ptIS0q34q0PqT636h9w+d X-Authentication-Warning: paranoia.hippie.lan: Host revolution.hippie.lan [172.22.42.240] claimed to be [172.22.42.240] Subject: Re: svn commit: r274926 - head/sys/dev/mpt From: Ian Lepore To: Dimitry Andric In-Reply-To: <33FD799A-274A-4797-8A0F-365B37868997@FreeBSD.org> References: <201411232137.sANLbY0F097559@svn.freebsd.org> <33FD799A-274A-4797-8A0F-365B37868997@FreeBSD.org> Content-Type: text/plain; charset="us-ascii" Date: Sun, 23 Nov 2014 14:54:32 -0700 Message-ID: <1416779672.1147.349.camel@revolution.hippie.lan> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Nov 2014 21:54:41 -0000 On Sun, 2014-11-23 at 22:47 +0100, Dimitry Andric wrote: > On 23 Nov 2014, at 22:37, Ian Lepore wrote: > > > > Author: ian > > Date: Sun Nov 23 21:37:33 2014 > > New Revision: 274926 > > URL: https://svnweb.freebsd.org/changeset/base/274926 > > > > Log: > > Squelch a (bogus) used before init warning when building with gcc. > > There have been quite a number of commits now for silencing gcc's mostly > incorrect used-before-init warnings. Of course, this is due to base gcc > being very old. So maybe it's time to start using -Wno-uninitialized > for gcc 4.2 and earlier? > > -Dimitry > It does seem like just sprinking trash over the source code. Does clang warn properly (or at least better than gcc does), or if we squelch this will we have no warnings at all? Hmmm, coverity should tell us if we introduce new use-before-inits, right? -- Ian