From owner-freebsd-current@FreeBSD.ORG  Thu Jul 29 02:23:50 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id D17A716A4CE; Thu, 29 Jul 2004 02:23:50 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id C43B543D1F; Thu, 29 Jul 2004 02:23:50 +0000 (GMT)
	(envelope-from kan@FreeBSD.org)
Received: from freefall.freebsd.org (kan@localhost [127.0.0.1])
	i6T2NYZf047435;	Thu, 29 Jul 2004 02:23:34 GMT
	(envelope-from kan@freefall.freebsd.org)
Received: (from kan@localhost)
	by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i6T2NXnu047434;
	Thu, 29 Jul 2004 02:23:33 GMT
	(envelope-from kan)
Date: Thu, 29 Jul 2004 02:23:33 +0000
From: Alexander Kabaev <kan@freebsd.org>
To: Marius Strobl <marius@alchemy.franken.de>
Message-ID: <20040729022333.GA47288@freefall.freebsd.org>
References: <41078B9E.2030603@mcsi.pp.ru>
	<20040728113014.GV82302@elvis.mu.org> <4107BE27.6050003@mcsi.pp.ru>
	<4107C519.5040101@mcsi.pp.ru> <20040728160619.GA13608@elvis.mu.org>
	<20040728183455.B57988@newtrinity.zeist.de>
	<20040728232332.C57988@newtrinity.zeist.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040728232332.C57988@newtrinity.zeist.de>
User-Agent: Mutt/1.4.1i
cc: Maxim Maximov <mcsi@mcsi.pp.ru>
cc: current@freebsd.org
Subject: Re: -fformat-extensions (was: Re: build is broken after gcc import)
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Jul 2004 02:23:50 -0000

On Wed, Jul 28, 2004 at 11:23:32PM +0200, Marius Strobl wrote:
> On Wed, Jul 28, 2004 at 06:34:55PM +0200, Marius Strobl wrote:
> > On Wed, Jul 28, 2004 at 06:06:19PM +0200, Maxime Henrion wrote:
> > > Maxim Maximov wrote:
> > > > Maxim Maximov wrote:
> > > > >cc1: error: unrecognized command line option "-fformat-extensions"
> > > > >*** Error code 1
> > > 
> > > It seems you have cvsup'ed at a bad time.  The -fformat-extensions
> > > option is a FreeBSD-specific (and NetBSD, I've been told) option, and
> > > is not in GCC baseline.  It has been merged back in revision 1.24 of
> > > src/contrib/gcc/toplev.c.  Can you check that you have the latest
> > > version of this file?  If you don't just re-cvsup and try again.
> > > 
> > 
> > Looks rather like Alexander forgot to commit the patch below, taken
> > from his http://people.freebsd.org/~kan/gcc341.tar.gz.
> > 
> 
> Ok, that patch misses the part for c-opts.c which is also needed to
> recognize "-fformat-extensions". But I don't see how this option
> is supposed to work, even before the GCC 3.4.2 import c-format.c
> didn't use flag_format_extensions but seems to use these extensions
> unconditionally.

You are correct. This flag was not really doing anything for the most of
FreeBSD-5 lifetime. I will probably remove it altogether in 6.x.

I committed the fix for now.

--
Alexander Kabaev