From owner-svn-src-all@FreeBSD.ORG Thu Jun 9 18:40:37 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 909B2106566C; Thu, 9 Jun 2011 18:40:37 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 67C048FC17; Thu, 9 Jun 2011 18:40:37 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 1D89546B4C; Thu, 9 Jun 2011 14:40:37 -0400 (EDT) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id AF0D18A01F; Thu, 9 Jun 2011 14:40:36 -0400 (EDT) From: John Baldwin To: gibbs@freebsd.org Date: Thu, 9 Jun 2011 14:40:35 -0400 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110325; KDE/4.5.5; amd64; ; ) References: <201105031854.p43IsIJ5006816@svn.freebsd.org> <4DF101F9.4020600@FreeBSD.org> In-Reply-To: <4DF101F9.4020600@FreeBSD.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201106091440.36182.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Thu, 09 Jun 2011 14:40:36 -0400 (EDT) Cc: svn-src-head@freebsd.org, "Andrey V. Elsukov" , svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r221397 - in head/sys: kern sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jun 2011 18:40:37 -0000 On Thursday, June 09, 2011 1:25:13 pm Justin T. Gibbs wrote: > On 5/3/11 12:54 PM, Andrey V. Elsukov wrote: > > Author: ae > > Date: Tue May 3 18:54:18 2011 > > New Revision: 221397 > > URL: http://svn.freebsd.org/changeset/base/221397 > > > > Log: > > Add make_dev_alias_p() function. It is similar to make_dev_alias(), > > but it may return an error like make_dev_p() does. > > Sorry for the late reply on this change. I noticed it during some recent > merge activity at work where my make_dev_credv() conflicted with your > make_dev_cred_v(). > > It seems that the existing convention in this file for "function variants" > is to append a single letter to the function name without an underscore > (e.g. make_dev_credv, make_dev_credf). make_dev_alias_v() and make_dev_p(), > break this convention. It would be nice to clean up this API so that > the naming conventions are consistent. So which should it be? Underscore > or no underscore? Hmm, could we take advantage of 9 being an API "breaking point" to simplify the API back down so there are fewer variants perhaps? Maybe we could make the 'flags' argument to make_dev() mandatory and change make_dev and make_dev_alias to always use the _p semantics (return an error and use a parameter to optionally return the new cdev)? -- John Baldwin