From nobody Thu Dec 7 03:59:22 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Sm0sT2lDBz53WKy; Thu, 7 Dec 2023 03:59:57 +0000 (UTC) (envelope-from sjg@juniper.net) Received: from mx0b-00273201.pphosted.com (mx0b-00273201.pphosted.com [67.231.152.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.pphosted.com", Issuer "Sectigo RSA Organization Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Sm0sS6bNtz3J9x; Thu, 7 Dec 2023 03:59:56 +0000 (UTC) (envelope-from sjg@juniper.net) Authentication-Results: mx1.freebsd.org; none Received: from pps.filterd (m0108163.ppops.net [127.0.0.1]) by mx0b-00273201.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3B73XY8q003830; Wed, 6 Dec 2023 19:59:55 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; h=to : cc : subject : in-reply-to : references : from : mime-version : content-type : content-id : date : message-id; s=PPS1017; bh=rVX8y1kjoTybLiQ/3Y56KEMMiU/p7xKMlJ5PtRTudoE=; b=zxAlKrclFyv6C+Q6Xei6i1o4ggaVhBvgyy3xpObfFGmEBf9YheqKsfYC6nQqzwv0NiwL MvBOEX84lMrXBrmMeZ8KLXc6e5EO58wQLGGYwXl7Qvl8Ka3WGpzRQh183Eg71chQurh0 TQMB/cu5/MDdWZifWssa9LwdRFYhtM8QKXg2El0IuSWVZBXtsuucoaNaIfRXUDcaYENg k3vYsOWo6fOsD9zsKg53+fLCXkDDtuH2wVdRG8K1rkzM8Bx+ZHZugTGv9JbH1LA2FfVa R099g8HDA+gSLU+oUTfUgtqXBzS75wFE67KCaiKuHnrzmEMBgibDixCgJJoPh3LXlm/N QQ== Received: from cy4pr02cu008.outbound.protection.outlook.com (mail-westcentralusazlp17012028.outbound.protection.outlook.com [40.93.6.28]) by mx0b-00273201.pphosted.com (PPS) with ESMTPS id 3utvh6hvu2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 06 Dec 2023 19:59:55 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ty5lBZQ8HFWL3iiVXGBZtODhNoMqsmBpyAhVXef3sd7MUfoBLPVmDCT5KE1bXjPdfMJKsWgTggpHSPTApHVIHWPQP/rNRKqk0AAGhA0KKJ0y85hkEz0gTMQUiKLoxF3/u4IcQd/oBg058WZ8oUHpenVxl0gLmd186t3fAf4cpcbHaaMnRp/eQ/FcP6N7PhebhP1nZInyRDgsgWiUkdw3RGV2LonRiWsJ+w7KgOw/Bwxlt3JpmiXgx9q7hfI9Tlzq/WTMVvn+0SY8HMlJEDuzfj6GivWCtyv0ml5pLX45a5JzdseuCO75BF+VpRIfwsG6eTIcFMgCCmmZSAP5ejmHYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rVX8y1kjoTybLiQ/3Y56KEMMiU/p7xKMlJ5PtRTudoE=; b=c85TDXFNFfqQq0WCEQsfSlNP0ClCUqz7I5AXOAaWIfcPn4mj8cAi4mebIOiko4ZmT4I7JTiO3JFdJ/owFUPbA7E1TTkMLxztbf34WawZweJhmLQwBJe4FzsRC97u4ZznK/rIygorrM4mZJ/O4r1aRPe1/1xe6MBemEu9JnRPDF09JEji1eDu7M70ZKq7cXIY9rGPdzHAh8mFPXB2svytEQ4haGOPfIFJ4eaFNO08MzfjS0rQxKBdMe9pVitnWplHDogXRNQO39VXdqEpR9Q2G6PjT0xtXkY8J1iYAruDYqYq4pSUzypEZJDYRrmBRO3rQMTQTvLyL39EErZH5DfrRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 66.129.242.15) smtp.rcpttodomain=freebsd.org smtp.mailfrom=juniper.net; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=juniper.net; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rVX8y1kjoTybLiQ/3Y56KEMMiU/p7xKMlJ5PtRTudoE=; b=YU8QBTIbeJu8E/8p6I8K9jTM2gJ2XGQ9S48DyJC3v+s/Kc4H8UkVUX7vqKPMF061JvbI5qumg5jwSbMp2/cQHo7bbQcBNZki3MS5ZwOIsU3629qQ+IErkYcuBHKNGg6S0uC3cf+SNCOtvU6aWHASTLwH5fLfIx5UU+C9l16ni20= Received: from BN6PR17CA0038.namprd17.prod.outlook.com (2603:10b6:405:75::27) by CH3PR05MB9387.namprd05.prod.outlook.com (2603:10b6:610:142::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.25; Thu, 7 Dec 2023 03:59:53 +0000 Received: from BN8NAM12FT079.eop-nam12.prod.protection.outlook.com (2603:10b6:405:75:cafe::f4) by BN6PR17CA0038.outlook.office365.com (2603:10b6:405:75::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.34 via Frontend Transport; Thu, 7 Dec 2023 03:59:53 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 66.129.242.15) smtp.mailfrom=juniper.net; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=juniper.net; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning juniper.net discourages use of 66.129.242.15 as permitted sender) Received: from p-exchfe-eqx-02.jnpr.net (66.129.242.15) by BN8NAM12FT079.mail.protection.outlook.com (10.13.182.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.6 via Frontend Transport; Thu, 7 Dec 2023 03:59:52 +0000 Received: from p-exchbe-eqx-02.jnpr.net (10.104.9.15) by p-exchfe-eqx-02.jnpr.net (10.104.9.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39; Wed, 6 Dec 2023 21:59:52 -0600 Received: from p-exchbe-eqx-01.jnpr.net (10.104.9.14) by p-exchbe-eqx-02.jnpr.net (10.104.9.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39; Wed, 6 Dec 2023 21:59:51 -0600 Received: from p-mailhub01.juniper.net (10.104.20.6) by p-exchbe-eqx-01.jnpr.net (10.104.9.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39 via Frontend Transport; Wed, 6 Dec 2023 21:59:51 -0600 Received: from kaos.jnpr.net (kaos.jnpr.net [172.23.255.201]) by p-mailhub01.juniper.net (8.14.4/8.11.3) with ESMTP id 3B73xp37008330; Wed, 6 Dec 2023 19:59:51 -0800 (envelope-from sjg@juniper.net) Received: by kaos.jnpr.net (Postfix, from userid 1377) id BFA224D68C; Wed, 6 Dec 2023 19:59:22 -0800 (PST) Received: from kaos.jnpr.net (localhost [127.0.0.1]) by kaos.jnpr.net (Postfix) with ESMTP id BF0EA4D376; Wed, 6 Dec 2023 19:59:22 -0800 (PST) To: Warner Losh CC: src-committers , "" , "" , Subject: Re: git: 83d0b8c089d8 - main - bsdinstall generate opt_osname.h in include In-Reply-To: References: <202312070235.3B72ZoZp043061@gitrepo.freebsd.org> Comments: In-reply-to: Warner Losh message dated "Wed, 06 Dec 2023 20:32:10 -0700." From: "Simon J. Gerraty" X-Mailer: MH-E 8.6+git; nmh 1.8; GNU Emacs 28.2 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <68563.1701921562.1@kaos.jnpr.net> Date: Wed, 6 Dec 2023 19:59:22 -0800 Message-ID: <71239.1701921562@kaos.jnpr.net> X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM12FT079:EE_|CH3PR05MB9387:EE_ X-MS-Office365-Filtering-Correlation-Id: e6853ae3-8936-4d0b-2e4a-08dbf6d8f788 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DMqlR4IUNuMTDdXqgRtiu4lSU5vl0gRyZut7M4uoodisigLccZAilQIpYDEvQ1nbih954vK0Z0cq3v10I0N8j4iZOYIakAfoBGc35/UJJCT3+W5QW7kGTnJVcXs+DNj4m5VM/Is4WuB04SSs//cLS/bgE0emWG4JGFNtZo3/2i5vWyT7emREKJFPpWXkl7sVhHJarbXXE0ic5g8uZJHM6ieYdSiQWZ1h/UFUcGCarf8WXr1GonvvTjsFf/qfQlJzt1qHncn7KAbPRfkUhr5kIeYLvTnfUEisksqzjG38Y+gZ2rqdzOyyF1K45GJ6SXfAiPvFDwHo4DCB0oTg4A2BXWEUQqrRN5vOJ0cw1ZTdDKhYAJtqxcnKaKH9mh8HF5forL2t16g/R+xslu0nNXIhCYyQePZkzVFNiRX1SVSnUyUOKIXzXGjy16/vySi7ge+TFVLgE7i+e9ez8SGLx3kPJX7T9977Tt4sVK7bNGngucKcffp0Iu9hpQojsRJ9Nj3PDc3AL+Md8QIrvk0x0OdAG+aoL6h4OeLdmNF5fVyTxKt5Wsy8TlyW6XwkO6p5Y6FH1TeX9VNwcDLa84Prjy2e8mC2bTABpKiWN/NzTmPyn5rhROnOY/m4DykbzMrhVPL9LjM0Y6OesmWpjCUAHSHCDD60PYycErGZjHBN//7PUgtwvE7zZmpUKKmQotGPXgON3fF5qVX6wHNfPKwXYzsr+tu1nFYMGZa7jcTEfwq0CyHAa6+eL/e6BS0P7UXi5XudxIo+tuaz2N4rNnrcuVdX4wKdgWoKuMrOS1OLCI+C3pYl9egiNCLZ8+/PA9b0/R7/ X-Forefront-Antispam-Report: CIP:66.129.242.15;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:p-exchfe-eqx-02.jnpr.net;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(4636009)(39860400002)(346002)(376002)(396003)(136003)(230922051799003)(82310400011)(186009)(1800799012)(64100799003)(451199024)(46966006)(40470700004)(36840700001)(9686003)(107886003)(7126003)(40460700003)(336012)(6266002)(26005)(86362001)(41300700001)(8676002)(8936002)(2906002)(558084003)(4326008)(5660300002)(54906003)(70206006)(70586007)(316002)(6916009)(7696005)(478600001)(47076005)(81166007)(356005)(82740400003)(55016003)(36860700001)(40480700001)(36900700001);DIR:OUT;SFP:1102; X-OriginatorOrg: juniper.net X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2023 03:59:52.7916 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e6853ae3-8936-4d0b-2e4a-08dbf6d8f788 X-MS-Exchange-CrossTenant-Id: bea78b3c-4cdb-4130-854a-1d193232e5f4 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bea78b3c-4cdb-4130-854a-1d193232e5f4;Ip=[66.129.242.15];Helo=[p-exchfe-eqx-02.jnpr.net] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM12FT079.eop-nam12.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR05MB9387 X-Proofpoint-GUID: NDQZT-6LvRzzLwGXdeYJepx9eIinXP0O X-Proofpoint-ORIG-GUID: NDQZT-6LvRzzLwGXdeYJepx9eIinXP0O X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-07_01,2023-12-06_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 adultscore=0 mlxlogscore=429 phishscore=0 spamscore=0 priorityscore=1501 mlxscore=0 bulkscore=0 impostorscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2312070031 X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:22843, ipnet:67.231.152.0/24, country:US] X-Spamd-Bar: ---- X-Rspamd-Queue-Id: 4Sm0sS6bNtz3J9x Warner Losh wrote: > Silly question: why not just add it to CFLAGS with > -DOSNAME=\"${OSNAME}\" rather than generating this file? Actually it is an excellent question - I've no idea why opt_osname.h is needed.