From nobody Sun Jul 26 21:27:47 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4h7ZZX1V6sz6lvhv for ; Sun, 26 Jul 2026 21:27:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4h7ZZX0v0Nz3hLd for ; Sun, 26 Jul 2026 21:27:48 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785101268; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7G59sYz8i3VzxJsd5LuvcpfzBMoSPmgRd3mZmrkxyeI=; b=jPuN5IcbDBYGqXg9qn+ZHY61wwTAaKdRQt3cEs76TjosrhBEoNueXrk7CvNQsGFj+OIoun mCtNz7F3OKaln+hfqXsAMMqsUL/2iHfT6J5AmU3YDhk8rFfEcN1UEAtDMwx4ZyQBUf4iU/ 21TEvTYyFdqXCl01wmRFD0qDF4ebgLmJ0aCpGkdQjw5/ywMoMcSQ3cVCjgnq8toT0pwv4c FtFdNae+vO1wqLxo3FE1LcLyBJDkAFxtccYjAEgr3U7L2IzEfCFSKvdvzZXYrX4s+GSjz8 ybC5G7zAqdoNcwwoUhAiQr+TViiTicYApaAZoI8lXKXRRUPnOz65q6Rb5s5GgQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785101268; a=rsa-sha256; cv=none; b=FYDKjvj9jyJS+IVWBc1v0IOHUpbgDU1OQZgd1jFgU91MfPAyE3qfhr/TOoB+yLkYrpGWo7 T1FzqsiiZbhB3ZI7ubisPKR1OoREKPgtUsS0AkoytIMf8x1WFruXE1WMpzxg+91ctfi7/6 kncITEJdvhyRquW3iUOVcRZSpBfCCX/0yAzu+zcN5RwoJGGWEApS5fskxu5/FU5lpknWhv +jtuIM8/02nenFnUuicQSOefahSu0WCAcS6VZz/L0UqeSIjIN8+c8ataZso75jKGlO4EJv dUhWsTnkUgdL+LNOOJ9maP6WR2rME3QXt0KD2RXY4c96K95A9bfA/7MAkxEU2g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785101268; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7G59sYz8i3VzxJsd5LuvcpfzBMoSPmgRd3mZmrkxyeI=; b=lq3LyuAM+v2gB5APD0AXqwTIIFLsto9yLeJ3jXX5b0YkJH/i5kA1fZ9zkSWDWG2XKfb+tQ FhiI4+rr2nmkqxrXLie6djAyztGZjgFJPJhHbU4ewjputVTMFnQdxHNtx3c0X5d00x3JoX D+rToDtrHvZhLKXc6cpQFwmu1YoaF+mVSD37cNJUMpwk6WJXyyeqPVRvO30lvvpHnPJja8 p7xWwjl47ErPZLw+O3owZp7xZC3sWGJLpNlJuYkIr7tbWlwoLbmMhmMpX1Ilclm6HtQ1p0 +fBkW/OWz1TPXYBlaxGIVUxtzFrDP7fsX/Blh/D6AM6K//pWpWmCtiOw8EPHdA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4h7ZZW6nngzftn for ; Sun, 26 Jul 2026 21:27:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 426ed by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 26 Jul 2026 21:27:47 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Joerg Wunsch Subject: git: 34ae0f7834d1 - main - cam/cd: avoid integer divide fault in cdstart() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: joerg X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 34ae0f7834d1bd6bb765d1c12e57e01e32b3e060 Auto-Submitted: auto-generated Date: Sun, 26 Jul 2026 21:27:47 +0000 Message-Id: <6a667bd3.426ed.1ab5a52e@gitrepo.freebsd.org> The branch main has been updated by joerg: URL: https://cgit.FreeBSD.org/src/commit/?id=34ae0f7834d1bd6bb765d1c12e57e01e32b3e060 commit 34ae0f7834d1bd6bb765d1c12e57e01e32b3e060 Author: Joerg Wunsch AuthorDate: 2026-07-26 20:54:01 +0000 Commit: Joerg Wunsch CommitDate: 2026-07-26 21:25:53 +0000 cam/cd: avoid integer divide fault in cdstart() If something goes very badly (e.g. forcibly removing a medium while the OS tries to start it), this could end up in params.blksize being 0 (and params.disksize 1). Avoid an integer divide fault, panicking the kernel, by bailing out before. MFC after: 3 days --- sys/cam/scsi/scsi_cd.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/sys/cam/scsi/scsi_cd.c b/sys/cam/scsi/scsi_cd.c index e622a96ec77e..1e8dc98d53f4 100644 --- a/sys/cam/scsi/scsi_cd.c +++ b/sys/cam/scsi/scsi_cd.c @@ -918,6 +918,16 @@ cdstart(struct cam_periph *periph, union ccb *start_ccb) return; } + if (softc->params.blksize == 0) { + /* + * Something went utterly wrong. + * Avoid integer divide fault below. + */ + biofinish(bp, NULL, ENXIO); + xpt_release_ccb(start_ccb); + return; + } + scsi_read_write(&start_ccb->csio, /*retries*/ cd_retry_count, /* cbfcnp */ cddone,