From owner-freebsd-current@FreeBSD.ORG  Thu Mar 18 03:51:05 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id A4F2316A4CE; Thu, 18 Mar 2004 03:51:05 -0800 (PST)
Received: from smtp.des.no (flood.des.no [217.116.83.31])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 395F643D49; Thu, 18 Mar 2004 03:51:05 -0800 (PST)
	(envelope-from des@des.no)
Received: by smtp.des.no (Pony Express, from userid 666)
	id 9BC14530E; Thu, 18 Mar 2004 12:51:03 +0100 (CET)
Received: from dwp.des.no (des.no [80.203.228.37])
	by smtp.des.no (Pony Express) with ESMTP
	id 533D3530A; Thu, 18 Mar 2004 12:50:57 +0100 (CET)
Received: by dwp.des.no (Postfix, from userid 2602)
	id 3113333CA7; Thu, 18 Mar 2004 12:50:57 +0100 (CET)
To: Marcel Moolenaar <marcel@xcllnt.net>
References: <20040317040254.386947303A@freebsd-current.sentex.ca>
	<xzpad2fhixn.fsf@dwp.des.no> <20040317113931.GF49920@ip.net.ua>
	<20040317200307.GA46126@ip.net.ua>
	<20040317205104.GA29066@dhcp01.pn.xcllnt.net>
	<20040317213014.GB46747@ip.net.ua>
	<20040318084128.GA59199@dhcp01.pn.xcllnt.net>
From: des@des.no (Dag-Erling =?iso-8859-1?q?Sm=F8rgrav?=)
Date: Thu, 18 Mar 2004 12:50:56 +0100
In-Reply-To: <20040318084128.GA59199@dhcp01.pn.xcllnt.net> (Marcel
 Moolenaar's message of "Thu, 18 Mar 2004 00:41:28 -0800")
Message-ID: <xzpu10m5q73.fsf@dwp.des.no>
User-Agent: Gnus/5.090024 (Oort Gnus v0.24) Emacs/21.3 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on flood.des.no
X-Spam-Level: 
X-Spam-Status: No, hits=0.0 required=5.0 tests=AWL autolearn=no version=2.63
cc: ia64@FreeBSD.org
cc: Ruslan Ermilov <ru@FreeBSD.org>
cc: FreeBSD Tinderbox <tinderbox@FreeBSD.org>
cc: current@FreeBSD.org
Subject: Re: [current tinderbox] failure on ia64/ia64
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Mar 2004 11:51:05 -0000

Marcel Moolenaar <marcel@xcllnt.net> writes:
> The source code appears to be fishy. The variable v is never used.
> It's only defined. If you change the "return mask" to a "return v",
> the warning goes away.

I suspect that there's a line missing:

@@ -548,4 +548,5 @@
        }
        DEB(printf("sv_mix_setrecsrc: mask 0x%08x adc_input 0x%02x\n", mask=
, v));
+       sv_indirect_set(sc, SV_REG_ADC_INPUT, v);
        return mask;
 }

although I have no way of testing this.

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no