From owner-svn-src-projects@FreeBSD.ORG Mon Nov 24 10:48:58 2014
Return-Path: <owner-svn-src-projects@FreeBSD.ORG>
Delivered-To: svn-src-projects@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by hub.freebsd.org (Postfix) with ESMTPS id 0C85380E;
Mon, 24 Nov 2014 10:48:58 +0000 (UTC)
Received: from mail.ipfw.ru (mail.ipfw.ru [IPv6:2a01:4f8:120:6141::2])
(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
(Client did not present a certificate)
by mx1.freebsd.org (Postfix) with ESMTPS id C5D5DFC9;
Mon, 24 Nov 2014 10:48:57 +0000 (UTC)
Received: from [2a02:6b8:0:401:222:4dff:fe50:cd2f] (helo=ptichko.yndx.net)
by mail.ipfw.ru with esmtpsa (TLSv1:DHE-RSA-AES128-SHA:128)
(Exim 4.82 (FreeBSD)) (envelope-from <melifaro@FreeBSD.org>)
id 1XsnBD-000EXj-13; Mon, 24 Nov 2014 10:31:23 +0400
Message-ID: <54730D08.3070201@FreeBSD.org>
Date: Mon, 24 Nov 2014 14:48:40 +0400
From: "Alexander V. Chernikov" <melifaro@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
rv:31.0) Gecko/20100101 Thunderbird/31.1.2
MIME-Version: 1.0
To: Gleb Smirnoff <glebius@FreeBSD.org>
Subject: Re: svn commit: r274921 - projects/routing/sys/net
References: <201411231747.sANHlC9Y088840@svn.freebsd.org>
<20141124065122.GE47144@FreeBSD.org>
In-Reply-To: <20141124065122.GE47144@FreeBSD.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org
X-BeenThere: svn-src-projects@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the src " projects"
tree" <svn-src-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-projects>,
<mailto:svn-src-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-projects/>
List-Post: <mailto:svn-src-projects@freebsd.org>
List-Help: <mailto:svn-src-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-projects>,
<mailto:svn-src-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Nov 2014 10:48:58 -0000
On 24.11.2014 10:51, Gleb Smirnoff wrote:
> On Sun, Nov 23, 2014 at 05:47:12PM +0000, Alexander V. Chernikov wrote:
> A> Author: melifaro
> A> Date: Sun Nov 23 17:47:12 2014
> A> New Revision: 274921
> A> URL: https://svnweb.freebsd.org/changeset/base/274921
> A>
> A> Log:
> A> Finish r274335#2: put RT_LOCK_DESTROY() back.
> A>
> A> Modified:
> A> projects/routing/sys/net/route.c
> A>
> A> Modified: projects/routing/sys/net/route.c
> A> ==============================================================================
> A> --- projects/routing/sys/net/route.c Sun Nov 23 17:45:49 2014 (r274920)
> A> +++ projects/routing/sys/net/route.c Sun Nov 23 17:47:12 2014 (r274921)
> A> @@ -1505,6 +1505,7 @@ rtrequest1_fib(int req, struct rt_addrin
> A> if (rn == NULL) {
> A> ifa_free(rt->rt_ifa);
> A> Free(rt_key(rt));
> A> + RT_LOCK_DESTROY(rt);
> A> uma_zfree(V_rtzone, rt);
> A> #ifdef FLOWTABLE
> A> if (rt0 != NULL)
>
> Don't know about your branch, but in head RT_LOCK_DESTROY is done
> in V_rtzone finit method. So you are going to hit destroying of
Well, since there is no place to do rte accounting, I reverted r262763,
so there is
no init/fini UMA methods.
> already destroyed mutex.
>
> btw, I see no good reason for virtualizing the zone. (Yep, I did that.) :)
>